* [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver
@ 2024-06-04 5:44 Heinrich Schuchardt
2024-06-04 6:38 ` Mattijs Korpershoek
2024-06-06 7:12 ` Mattijs Korpershoek
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2024-06-04 5:44 UTC (permalink / raw)
To: Lukasz Majewski, Mattijs Korpershoek
Cc: Tom Rini, Patrick Delaunay, Jaehoon Chung, Ashok Reddy Soma,
u-boot, Heinrich Schuchardt
Building the SPI flash DFU driver fails if SPI flash support is missing.
drivers/dfu/dfu_sf.c:123:29: error:
‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);
Add the missing dependency.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
drivers/dfu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
index 0360d9da142..971204758aa 100644
--- a/drivers/dfu/Kconfig
+++ b/drivers/dfu/Kconfig
@@ -68,6 +68,7 @@ config DFU_RAM
config DFU_SF
bool "SPI flash back end for DFU"
+ depends on SPI_FLASH || DM_SPI_FLASH
help
This option enables using DFU to read and write to SPI flash based
storage.
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver
2024-06-04 5:44 [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver Heinrich Schuchardt
@ 2024-06-04 6:38 ` Mattijs Korpershoek
2024-06-06 7:12 ` Mattijs Korpershoek
1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2024-06-04 6:38 UTC (permalink / raw)
To: Heinrich Schuchardt, Lukasz Majewski
Cc: Tom Rini, Patrick Delaunay, Jaehoon Chung, Ashok Reddy Soma,
u-boot, Heinrich Schuchardt
Hi Heinrich,
Thank you for the patch.
On mar., juin 04, 2024 at 07:44, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
> Building the SPI flash DFU driver fails if SPI flash support is missing.
>
> drivers/dfu/dfu_sf.c:123:29: error:
> ‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);
>
> Add the missing dependency.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/dfu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index 0360d9da142..971204758aa 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -68,6 +68,7 @@ config DFU_RAM
>
> config DFU_SF
> bool "SPI flash back end for DFU"
> + depends on SPI_FLASH || DM_SPI_FLASH
> help
> This option enables using DFU to read and write to SPI flash based
> storage.
> --
> 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver
2024-06-04 5:44 [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver Heinrich Schuchardt
2024-06-04 6:38 ` Mattijs Korpershoek
@ 2024-06-06 7:12 ` Mattijs Korpershoek
1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2024-06-06 7:12 UTC (permalink / raw)
To: Lukasz Majewski, Heinrich Schuchardt
Cc: Tom Rini, Patrick Delaunay, Jaehoon Chung, Ashok Reddy Soma,
u-boot
Hi,
On Tue, 04 Jun 2024 07:44:25 +0200, Heinrich Schuchardt wrote:
> Building the SPI flash DFU driver fails if SPI flash support is missing.
>
> drivers/dfu/dfu_sf.c:123:29: error:
> ‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);
>
> Add the missing dependency.
>
> [...]
Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu)
[1/1] dfu: add missing dependency for SPI flash DFU driver
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/4339138a2086f8449b9356130cb6e97a81aa8679
--
Mattijs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-06 7:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-04 5:44 [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver Heinrich Schuchardt
2024-06-04 6:38 ` Mattijs Korpershoek
2024-06-06 7:12 ` Mattijs Korpershoek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox