Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

[Mathieu Othacehe <m.othacehe@gmail.com>]

Hello,

> Please remove findfdt script.
>
> Not needed when you set fdt_file to CONFIG_DEFAULT_FDT_FILE above.

The reason I used findfdt is that CONFIG_DEFAULT_FDT_FILE is a string
so, we end up with:

--8<---------------cut here---------------start------------->8---
fdt_file="oftree"
--8<---------------cut here---------------end--------------->8---

which gives:

--8<---------------cut here---------------start------------->8---
u-boot=> run loadfdt
Failed to load '"oftree"'
--8<---------------cut here---------------end--------------->8---

whereas, if I set:

--8<---------------cut here---------------start------------->8---
u-boot=> setenv fdt_file oftree
u-boot=> run loadfdt           
24579 bytes read in 5 ms (4.7 MiB/s)
--8<---------------cut here---------------end--------------->8---

I then see three options: introduce an unstrigify macro, hardcode
fdt_file=oftree in the env file, or use the findfdt hack.

I'm not sure which one is the better?

I will fix all the other remarks in the v4.

Thanks,

Mathieu