From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>,
Marek Vasut <marek.vasut@mailbox.org>
Subject: Re: [PATCH] usb: gadget: spl: Add missing dependency for SPL_USB_GADGET
Date: Mon, 06 Oct 2025 09:41:17 +0200 [thread overview]
Message-ID: <87ikgswk82.fsf@kernel.org> (raw)
In-Reply-To: <20251003203922.1029989-1-trini@konsulko.com>
Hi Tom,
Thank you for the patch.
On Fri, Oct 03, 2025 at 14:39, Tom Rini <trini@konsulko.com> wrote:
> It makes no sense to ask about nor enable SPL_USB_GADGET without
> SPL_FRAMEWORK being enabled. Attempting to do so leads to Kconfig noting
> dependency issues. Add the missing dependency.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> Cc: Marek Vasut <marek.vasut@mailbox.org>
> ---
> drivers/usb/gadget/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 882f082c9cdb..056eff4d942e 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -39,6 +39,7 @@ menuconfig USB_GADGET
>
> config SPL_USB_GADGET
> bool "USB Gadget Support in SPL"
> + depends on SPL_FRAMEWORK
> help
> Enable USB Gadget API which allows to enable USB device functions
> in SPL.
> --
> 2.43.0
prev parent reply other threads:[~2025-10-06 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 20:39 [PATCH] usb: gadget: spl: Add missing dependency for SPL_USB_GADGET Tom Rini
2025-10-06 7:41 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikgswk82.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=marek.vasut@mailbox.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox