U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: spl: Add missing dependency for SPL_USB_GADGET
@ 2025-10-03 20:39 Tom Rini
  2025-10-06  7:41 ` Mattijs Korpershoek
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Rini @ 2025-10-03 20:39 UTC (permalink / raw)
  To: u-boot; +Cc: Mattijs Korpershoek, Marek Vasut

It makes no sense to ask about nor enable SPL_USB_GADGET without
SPL_FRAMEWORK being enabled. Attempting to do so leads to Kconfig noting
dependency issues. Add the missing dependency.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: Marek Vasut <marek.vasut@mailbox.org>
---
 drivers/usb/gadget/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 882f082c9cdb..056eff4d942e 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -39,6 +39,7 @@ menuconfig USB_GADGET
 
 config SPL_USB_GADGET
 	bool "USB Gadget Support in SPL"
+	depends on SPL_FRAMEWORK
 	help
 	  Enable USB Gadget API which allows to enable USB device functions
 	  in SPL.
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: gadget: spl: Add missing dependency for SPL_USB_GADGET
  2025-10-03 20:39 [PATCH] usb: gadget: spl: Add missing dependency for SPL_USB_GADGET Tom Rini
@ 2025-10-06  7:41 ` Mattijs Korpershoek
  0 siblings, 0 replies; 2+ messages in thread
From: Mattijs Korpershoek @ 2025-10-06  7:41 UTC (permalink / raw)
  To: Tom Rini, u-boot; +Cc: Mattijs Korpershoek, Marek Vasut

Hi Tom,

Thank you for the patch.

On Fri, Oct 03, 2025 at 14:39, Tom Rini <trini@konsulko.com> wrote:

> It makes no sense to ask about nor enable SPL_USB_GADGET without
> SPL_FRAMEWORK being enabled. Attempting to do so leads to Kconfig noting
> dependency issues. Add the missing dependency.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> Cc: Marek Vasut <marek.vasut@mailbox.org>
> ---
>  drivers/usb/gadget/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 882f082c9cdb..056eff4d942e 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -39,6 +39,7 @@ menuconfig USB_GADGET
>  
>  config SPL_USB_GADGET
>  	bool "USB Gadget Support in SPL"
> +	depends on SPL_FRAMEWORK
>  	help
>  	  Enable USB Gadget API which allows to enable USB device functions
>  	  in SPL.
> -- 
> 2.43.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-10-06  7:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-03 20:39 [PATCH] usb: gadget: spl: Add missing dependency for SPL_USB_GADGET Tom Rini
2025-10-06  7:41 ` Mattijs Korpershoek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox