* [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry
@ 2023-12-20 16:42 Mattijs Korpershoek
2023-12-21 14:15 ` Sam Protsenko
0 siblings, 1 reply; 3+ messages in thread
From: Mattijs Korpershoek @ 2023-12-20 16:42 UTC (permalink / raw)
To: Tom Rini; +Cc: Sam Protsenko, Igor Opaniuk, u-boot, Mattijs Korpershoek
Commit 19a91f2464a8 ("Create a new boot/ directory") moved the
android_ab.c code under boot/android_ab but did not update
the MAINTAINERS entry.
Update it so that the maintainer will get cc'ed again.
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7c1cb2dc4dc0..f6de883a7d8f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -60,8 +60,8 @@ ANDROID AB
M: Igor Opaniuk <igor.opaniuk@gmail.com>
R: Sam Protsenko <semen.protsenko@linaro.org>
S: Maintained
+F: boot/android_ab.c
F: cmd/ab_select.c
-F: common/android_ab.c
F: doc/android/ab.rst
F: include/android_ab.h
F: test/py/tests/test_android/test_ab.py
---
base-commit: 9e53e45292ee2f1d9d2ccc59914b161bef9b10d7
change-id: 20231220-maintainers-fix-ab-2afa7cee97bd
Best regards,
--
Mattijs Korpershoek <mkorpershoek@baylibre.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry
2023-12-20 16:42 [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry Mattijs Korpershoek
@ 2023-12-21 14:15 ` Sam Protsenko
2023-12-21 16:07 ` Mattijs Korpershoek
0 siblings, 1 reply; 3+ messages in thread
From: Sam Protsenko @ 2023-12-21 14:15 UTC (permalink / raw)
To: Mattijs Korpershoek; +Cc: Tom Rini, Igor Opaniuk, u-boot
Hi Mattijs,
On Wed, Dec 20, 2023 at 10:43 AM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
>
> Commit 19a91f2464a8 ("Create a new boot/ directory") moved the
> android_ab.c code under boot/android_ab but did not update
> the MAINTAINERS entry.
Thanks for the patch! Would you mind adding corresponding "Fixes" tag
below your Signed-off?
Other than that LGTM:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>
> Update it so that the maintainer will get cc'ed again.
>
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7c1cb2dc4dc0..f6de883a7d8f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -60,8 +60,8 @@ ANDROID AB
> M: Igor Opaniuk <igor.opaniuk@gmail.com>
> R: Sam Protsenko <semen.protsenko@linaro.org>
> S: Maintained
> +F: boot/android_ab.c
> F: cmd/ab_select.c
> -F: common/android_ab.c
> F: doc/android/ab.rst
> F: include/android_ab.h
> F: test/py/tests/test_android/test_ab.py
>
> ---
> base-commit: 9e53e45292ee2f1d9d2ccc59914b161bef9b10d7
> change-id: 20231220-maintainers-fix-ab-2afa7cee97bd
>
> Best regards,
> --
> Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry
2023-12-21 14:15 ` Sam Protsenko
@ 2023-12-21 16:07 ` Mattijs Korpershoek
0 siblings, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2023-12-21 16:07 UTC (permalink / raw)
To: Sam Protsenko; +Cc: Tom Rini, Igor Opaniuk, u-boot
Hi Sam,
Thank you for your review.
On Thu, Dec 21, 2023 at 08:15, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> Hi Mattijs,
>
> On Wed, Dec 20, 2023 at 10:43 AM Mattijs Korpershoek
> <mkorpershoek@baylibre.com> wrote:
>>
>> Commit 19a91f2464a8 ("Create a new boot/ directory") moved the
>> android_ab.c code under boot/android_ab but did not update
>> the MAINTAINERS entry.
>
> Thanks for the patch! Would you mind adding corresponding "Fixes" tag
> below your Signed-off?
I don't mind, will send a v2.
>
> Other than that LGTM:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>
>>
>> Update it so that the maintainer will get cc'ed again.
>>
>> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>> ---
>> MAINTAINERS | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7c1cb2dc4dc0..f6de883a7d8f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -60,8 +60,8 @@ ANDROID AB
>> M: Igor Opaniuk <igor.opaniuk@gmail.com>
>> R: Sam Protsenko <semen.protsenko@linaro.org>
>> S: Maintained
>> +F: boot/android_ab.c
>> F: cmd/ab_select.c
>> -F: common/android_ab.c
>> F: doc/android/ab.rst
>> F: include/android_ab.h
>> F: test/py/tests/test_android/test_ab.py
>>
>> ---
>> base-commit: 9e53e45292ee2f1d9d2ccc59914b161bef9b10d7
>> change-id: 20231220-maintainers-fix-ab-2afa7cee97bd
>>
>> Best regards,
>> --
>> Mattijs Korpershoek <mkorpershoek@baylibre.com>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-21 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-20 16:42 [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry Mattijs Korpershoek
2023-12-21 14:15 ` Sam Protsenko
2023-12-21 16:07 ` Mattijs Korpershoek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox