public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: sjg@chromium.org, philipp.tomsich@vrull.eu,
	kever.yang@rock-chips.com, gajjar04akash@gmail.com,
	abbaraju.manojsai@amarulasolutions.com,
	jagan@amarulasolutions.com, john@metanate.com,
	jianing.ren@rock-chips.com, u-boot@lists.denx.de,
	anarsoul@gmail.com
Subject: Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates
Date: Tue, 07 Mar 2023 20:53:36 +0100	[thread overview]
Message-ID: <87o7p4cp8f.fsf@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20230307193748.25712-2-anarsoul@gmail.com> (message from Vasily Khoruzhick on Tue, 7 Mar 2023 11:37:48 -0800)

> From: Vasily Khoruzhick <anarsoul@gmail.com>
> Date: Tue,  7 Mar 2023 11:37:48 -0800
> 
> combphy0 is failing to probe due to unhandled assigned-clocks and
> assigned-clocks-rates.

That is probably the wrong approach.  It should be possible to boot an
OS with the device tree provided by U-Boot.  Removing these properties
means the OS doesn't see them either.  But if the assigned-clocks
property isn't needed it wouldn't be there would it?

> commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates")
> dropped these properties for combphy1, so let's drop them for combphy0 as well.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  arch/arm/dts/rk3568-evb-u-boot.dtsi     |  1 +
>  arch/arm/dts/rk3568-rock-3a-u-boot.dtsi |  1 +
>  arch/arm/dts/rk3568-u-boot.dtsi         | 11 +++++++++++
>  3 files changed, 13 insertions(+)
>  create mode 100644 arch/arm/dts/rk3568-u-boot.dtsi
> 
> diff --git a/arch/arm/dts/rk3568-evb-u-boot.dtsi b/arch/arm/dts/rk3568-evb-u-boot.dtsi
> index 17503d3d27..77430da3ba 100644
> --- a/arch/arm/dts/rk3568-evb-u-boot.dtsi
> +++ b/arch/arm/dts/rk3568-evb-u-boot.dtsi
> @@ -4,6 +4,7 @@
>   */
>  
>  #include "rk356x-u-boot.dtsi"
> +#include "rk3568-u-boot.dtsi"
>  
>  / {
>  	chosen {
> diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> index ed47efa44b..44cf33ed4b 100644
> --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> @@ -5,6 +5,7 @@
>   */
>  
>  #include "rk356x-u-boot.dtsi"
> +#include "rk3568-u-boot.dtsi"
>  
>  / {
>  	chosen {
> diff --git a/arch/arm/dts/rk3568-u-boot.dtsi b/arch/arm/dts/rk3568-u-boot.dtsi
> new file mode 100644
> index 0000000000..c6776666df
> --- /dev/null
> +++ b/arch/arm/dts/rk3568-u-boot.dtsi
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2023 Vasily Khoruzhick <anarsoul@gmail.com>
> + */
> +
> +#include "rockchip-u-boot.dtsi"
> +
> +&combphy0 {
> +	/delete-property/ assigned-clocks;
> +	/delete-property/ assigned-clock-rates;
> +};
> -- 
> 2.39.2
> 
> 

  reply	other threads:[~2023-03-07 19:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 19:37 [PATCH 1/2] phy: rockchip-inno-usb2: add support for phy-supply Vasily Khoruzhick
2023-03-07 19:37 ` [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates Vasily Khoruzhick
2023-03-07 19:53   ` Mark Kettenis [this message]
2023-03-07 20:34     ` Vasily Khoruzhick
2023-03-07 21:04       ` Mark Kettenis
2023-03-07 21:34         ` Vasily Khoruzhick
2023-03-08  0:35           ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7p4cp8f.fsf@bloch.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=abbaraju.manojsai@amarulasolutions.com \
    --cc=anarsoul@gmail.com \
    --cc=gajjar04akash@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=jianing.ren@rock-chips.com \
    --cc=john@metanate.com \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox