From: Peter Korsgaard <jacmet@sunsite.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] am33xx: fix the ddr_cmdtctrl structure
Date: Mon, 17 Jun 2013 22:13:46 +0200 [thread overview]
Message-ID: <87r4g0sdfp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1371477567-8418-1-git-send-email-ilya@compulab.co.il> (Ilya Ledvich's message of "Mon, 17 Jun 2013 16:59:27 +0300")
>>>>> "Ilya" == Ilya Ledvich <ilya@compulab.co.il> writes:
Ilya> Fix the wrong mapping between the DDR I/O control registers on
Ilya> AM33XX SoCs and the software representation in the SPL code. The
Ilya> most recent public TRM defines the following DDR I/O control
Ilya> registers offsets:
Ilya> * ddr_cmd0_ioctrl : offset 0x44E11404
Ilya> * ddr_cmd1_ioctrl : offset 0x44E11408
Ilya> * ddr_cmd2_ioctrl : offset 0x44E1140C
Ilya> * ddr_data0_ioctrl: offset 0x44E11440
Ilya> * ddr_data1_ioctrl: offset 0x44E11444
Ilya> While the struct ddr_cmdtctrl has also some reserved bits in the
Ilya> beginning. The struct is mapped to the address 0x44E11404. As a
Ilya> result "cm0ioctl" points to the ddr_cmd1_ioctrl register,
Ilya> "cm1ioctl" to the ddr_cmd2_ioctrl and etc. Registers
Ilya> ddr_cmd0_ioctrl and ddr_data0_ioctrl are never configured because
Ilya> of this mapping mismatch.
Ilya> Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
Reviewed-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-06-17 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:59 [U-Boot] [PATCH] am33xx: fix the ddr_cmdtctrl structure Ilya Ledvich
2013-06-17 20:13 ` Peter Korsgaard [this message]
2013-07-02 20:06 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4g0sdfp.fsf@dell.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox