public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: Peng Fan <peng.fan@nxp.com>,  Tom Rini <trini@konsulko.com>,
	 Stefano Babic <sbabic@denx.de>,
	 Fabio Estevam <festevam@gmail.com>,
	 "NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	 Christoph Stoidner <c.stoidner@phytec.de>,
	 Wadim Egorov <w.egorov@phytec.de>,
	u-boot@lists.denx.de,  upstream@lists.phytec.de
Subject: Re: [PATCH] Add Phytec i.MX93 support
Date: Thu, 18 Jan 2024 12:04:29 +0100	[thread overview]
Message-ID: <87ttnavr5u.fsf@gmail.com> (raw)
In-Reply-To: <9add814d-540b-4ddb-8cfc-261e62049d7e@norik.com> (Primoz Fiser's message of "Thu, 18 Jan 2024 11:47:52 +0100")


Hi,

Thanks for the review!

> s/imx93_phycore/phycore_imx93
>
> To fit into existing PHYTEC boards already in tree.

I deliberately picked that order so that it is aligned with most imx
boards already supported by u-boot.

The supported imx93 boards follow that pattern:

- imx93_var_som
- imx93_evk

So it felt natural to have:

- imx93_phycore

Plus the kernel device-trees are also following that order:

- imx93-phycore-xxx

On the other hand, it is true that the existing phycore boards use the
phytec_* pattern:

- phycore_am335x_r2
- phycore_imx8mm
- phycore_imx8mp
- phycore_rk3288/

So that will be confusing no matter the option that we choose.

I will come up with a v2 fixing your other remarks, but I think that
this should be addressed beforehand.

Thanks,

Mathieu

  reply	other threads:[~2024-01-18 12:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  7:52 [PATCH] Add Phytec i.MX93 support Mathieu Othacehe
2024-01-17 10:36 ` Fabio Estevam
2024-01-18 10:47 ` Primoz Fiser
2024-01-18 11:04   ` Mathieu Othacehe [this message]
2024-01-19  6:49     ` [Upstream] " Yannic Moog
2024-01-19  7:21 ` Yannic Moog
2024-01-24 13:30   ` Mathieu Othacehe
2024-01-24 13:46     ` Yannic Moog

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttnavr5u.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=c.stoidner@phytec.de \
    --cc=festevam@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=primoz.fiser@norik.com \
    --cc=sbabic@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=upstream@lists.phytec.de \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox