public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Yannic Moog <Y.Moog@phytec.de>
Cc: "festevam@gmail.com" <festevam@gmail.com>,
	 Christoph Stoidner <C.Stoidner@phytec.de>,
	 Wadim Egorov <W.Egorov@phytec.de>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH] Add Phytec i.MX93 support
Date: Wed, 24 Jan 2024 14:30:12 +0100	[thread overview]
Message-ID: <87a5ou6eqj.fsf@gnu.org> (raw)
In-Reply-To: <e88317c9172455727459367953e0bb2acbd63eab.camel@phytec.de> (Yannic Moog's message of "Fri, 19 Jan 2024 07:21:35 +0000")


Hello Yannic,

> As a heads-up: you need to rebase as am62 (doc) got applied by Tom.

Noted.

> Is the trusted-firmware-a upstream version working? If so, please use that instead.

It is but only on the master branch, so it might be better to stick to
the nxp-imx repository until a lts release is created.

>> +#include <config_distro_bootcmd.h>
>
> I don't see a specific reason to have this include separate?! Group it with the others, please.

Many other include files place it here, right after the
BOOT_TARGET_DEVICES macro, so I guess there must be a reason, even
though I am unsure why :).

Thanks,

Mathieu

  reply	other threads:[~2024-01-24 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  7:52 [PATCH] Add Phytec i.MX93 support Mathieu Othacehe
2024-01-17 10:36 ` Fabio Estevam
2024-01-18 10:47 ` Primoz Fiser
2024-01-18 11:04   ` Mathieu Othacehe
2024-01-19  6:49     ` [Upstream] " Yannic Moog
2024-01-19  7:21 ` Yannic Moog
2024-01-24 13:30   ` Mathieu Othacehe [this message]
2024-01-24 13:46     ` Yannic Moog

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5ou6eqj.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=C.Stoidner@phytec.de \
    --cc=W.Egorov@phytec.de \
    --cc=Y.Moog@phytec.de \
    --cc=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox