[PATCH v2] test/py: Use aligned address for overlays in 'extension' test

[PATCH v2] test/py: Use aligned address for overlays in 'extension' test

[Marek Vasut]

The 'extension' test would set 'extension_overlay_addr' variable to
decimal 4096 due to conversion in python. The 'extension_overlay_addr'
is however sampled using env_get_hex("extension_overlay_addr", 0);
which converts the 4096 to 0x4096 and uses that as DT overlay address,
which is unaligned. Fix this by setting extension_overlay_addr to 0x1000
as intended, which is aligned.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
---
V2: Use only %x
---
 test/py/tests/test_extension.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/py/tests/test_extension.py b/test/py/tests/test_extension.py
index 61223496054..6daab0c9782 100644
--- a/test/py/tests/test_extension.py
+++ b/test/py/tests/test_extension.py
@@ -38,7 +38,7 @@ def test_extension(ubman):
     assert('overlay1.dtbo' in output)
 
     ubman.run_command_list([
-        'setenv extension_overlay_addr %s' % (overlay_addr),
+        'setenv extension_overlay_addr %x' % (overlay_addr),
         'setenv extension_overlay_cmd \'host load hostfs - ${extension_overlay_addr} %s${extension_overlay_name}\'' % (os.path.join(ubman.config.build_dir, OVERLAY_DIR))])
 
     output = ubman.run_command('extension apply 0')
-- 
2.51.0

Re: [PATCH v2] test/py: Use aligned address for overlays in 'extension' test

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

On Thu, Nov 13, 2025 at 12:57:52PM +0100, Marek Vasut wrote:

> The 'extension' test would set 'extension_overlay_addr' variable to
> decimal 4096 due to conversion in python. The 'extension_overlay_addr'
> is however sampled using env_get_hex("extension_overlay_addr", 0);
> which converts the 4096 to 0x4096 and uses that as DT overlay address,
> which is unaligned. Fix this by setting extension_overlay_addr to 0x1000
> as intended, which is aligned.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] test/py: Use aligned address for overlays in 'extension' test

[Mattijs Korpershoek]

Hi Marek,

Thank you for the patch.

On Thu, Nov 13, 2025 at 12:57, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> The 'extension' test would set 'extension_overlay_addr' variable to
> decimal 4096 due to conversion in python. The 'extension_overlay_addr'
> is however sampled using env_get_hex("extension_overlay_addr", 0);
> which converts the 4096 to 0x4096 and uses that as DT overlay address,
> which is unaligned. Fix this by setting extension_overlay_addr to 0x1000
> as intended, which is aligned.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---

Re: [PATCH v2] test/py: Use aligned address for overlays in 'extension' test

[Tom Rini]

On Thu, 13 Nov 2025 12:57:52 +0100, Marek Vasut wrote:

> The 'extension' test would set 'extension_overlay_addr' variable to
> decimal 4096 due to conversion in python. The 'extension_overlay_addr'
> is however sampled using env_get_hex("extension_overlay_addr", 0);
> which converts the 4096 to 0x4096 and uses that as DT overlay address,
> which is unaligned. Fix this by setting extension_overlay_addr to 0x1000
> as intended, which is aligned.
> 
> [...]

Applied to u-boot/next, thanks!

[1/1] test/py: Use aligned address for overlays in 'extension' test
      commit: f74353099016a22500830adda2bb0558322b414c
-- 
Tom