Re: [PATCH v3 23/28] rockchip: rk356x-generic: Fix eMMC and SD-card pinctrl

[Kever Yang <kever.yang@rock-chips.com>]

On 2024/4/22 14:29, Jonas Karlman wrote:
> Add missing emmc_datastrobe and sdmmc0_det pinctrl to fix possible issue
> reading from eMMC or SD-card. Also use correct node for mmc1 alias.
>
> Fixes: 683f61a13f16 ("rockchip: board: Add minimal generic RK3566/RK3568 board")
> Fixes: 363cbd578169 ("rockchip: rk3568-generic: Enable eMMC HS200 mode")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
> v3: No change
> v2: Split patch
> ---
>   arch/arm/dts/rk3568-generic.dts | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/dts/rk3568-generic.dts b/arch/arm/dts/rk3568-generic.dts
> index 88eb1bfd2aab..3b9bf8052046 100644
> --- a/arch/arm/dts/rk3568-generic.dts
> +++ b/arch/arm/dts/rk3568-generic.dts
> @@ -12,7 +12,7 @@
>   
>   	aliases {
>   		mmc0 = &sdhci;
> -		mmc1 = &sdmmc;
> +		mmc1 = &sdmmc0;
>   	};
>   
>   	chosen {
> @@ -28,7 +28,7 @@
>   	no-sdio;
>   	non-removable;
>   	pinctrl-names = "default";
> -	pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd>;
> +	pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
>   	status = "okay";
>   };
>   
> @@ -39,7 +39,7 @@
>   	no-mmc;
>   	no-sdio;
>   	pinctrl-names = "default";
> -	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd>;
> +	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
>   	status = "okay";
>   };
>