public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL
Date: Wed, 24 Jul 2019 17:11:02 +0800	[thread overview]
Message-ID: <91f28792-2df2-d127-25ce-06d581418673@rock-chips.com> (raw)
In-Reply-To: <CALeDE9N1013OVyOVy3jpTZNarcM7=tBhBxRTtR5B70=jaGmcTA@mail.gmail.com>

Hi Manivannan,

On 2019/7/24 下午3:59, Peter Robinson wrote:
> On Mon, May 20, 2019 at 4:47 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
>> This commits enables booting from eMMC when using SPL on 96Boards
>> Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
>> already has the reloc flag, this works straightaway.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> ---
>>   arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
>>   arch/arm/dts/rk3399-rock960.dts         | 2 ++
>>   2 files changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> index 5256f6d3f2..7fb5072a9b 100644
>> --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> @@ -3,4 +3,5 @@
>>    * Copyright (C) 2019 Jagan Teki <jagan@amarulasolutions.com>
>>    */
>>
>> +#include "rk3399-u-boot.dtsi"
>>   #include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
>> diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts
>> index 7e06bc97e5..c8b9075c73 100644
>> --- a/arch/arm/dts/rk3399-rock960.dts
>> +++ b/arch/arm/dts/rk3399-rock960.dts
>> @@ -12,6 +12,8 @@
>>
>>          chosen {
>>                  stdout-path = "serial2:1500000n8";
>> +               u-boot,spl-boot-order = \
>> +                       &sdhci, &sdmmc;
> Shouldn't this bit be in the rk3399-rock960-u-boot.dtsi not
> rk3399-rock960.dts because it's U-Boot specific?


Peter is correct, all the update to dts by U-Boot should go to 
-u-boot.dtsi now,

could you update and send the patch again?


Thanks,
- Kever
>
>>          };
>>   };
>>
>> --
>> 2.17.1
>>

  reply	other threads:[~2019-07-24  9:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 15:46 [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL Manivannan Sadhasivam
2019-05-20 15:46 ` [U-Boot] [PATCH 2/2] arm: dts: ficus: " Manivannan Sadhasivam
2019-05-27  6:49   ` Kever Yang
2019-07-23 15:07     ` Manivannan Sadhasivam
2019-07-24  8:03   ` Peter Robinson
2019-05-27  6:49 ` [U-Boot] [PATCH 1/2] arm: dts: rock960: " Kever Yang
2019-07-23 15:06   ` Manivannan Sadhasivam
2019-07-24  7:59 ` Peter Robinson
2019-07-24  9:11   ` Kever Yang [this message]
2019-07-24  9:13   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91f28792-2df2-d127-25ce-06d581418673@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox