* [PATCH 2/3] net: lwip: remove superfluous newline at tftp help text
@ 2025-03-12 7:37 Michael Walle
2025-03-12 7:42 ` Michael Walle
2025-03-12 8:26 ` Jerome Forissier
0 siblings, 2 replies; 3+ messages in thread
From: Michael Walle @ 2025-03-12 7:37 UTC (permalink / raw)
To: Tom Rini, Jerome Forissier; +Cc: u-boot, Michael Walle
The help text has a newline at the end which will lead to an empty
line after the tftpboot when printing the help overview. Remove it.
Fixes: 4d4d7838127e ("net: lwip: add TFTP support and tftpboot command")
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
cmd/net-lwip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/net-lwip.c b/cmd/net-lwip.c
index 0fd446ecb20..249556243d6 100644
--- a/cmd/net-lwip.c
+++ b/cmd/net-lwip.c
@@ -17,7 +17,7 @@ U_BOOT_CMD(ping, 2, 1, do_ping, "send ICMP ECHO_REQUEST to network host",
#if defined(CONFIG_CMD_TFTPBOOT)
U_BOOT_CMD(tftpboot, 3, 0, do_tftpb,
- "boot image via network using TFTP protocol\n",
+ "boot image via network using TFTP protocol",
"[loadAddress] [[hostIPaddr:]bootfilename]");
#endif
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/3] net: lwip: remove superfluous newline at tftp help text
2025-03-12 7:37 [PATCH 2/3] net: lwip: remove superfluous newline at tftp help text Michael Walle
@ 2025-03-12 7:42 ` Michael Walle
2025-03-12 8:26 ` Jerome Forissier
1 sibling, 0 replies; 3+ messages in thread
From: Michael Walle @ 2025-03-12 7:42 UTC (permalink / raw)
To: Tom Rini, Jerome Forissier; +Cc: u-boot
Sorry this should have been individual patches. Please read the subject
as
"[PATCH 1/1]" or just "[PATCH]".
-michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] net: lwip: remove superfluous newline at tftp help text
2025-03-12 7:37 [PATCH 2/3] net: lwip: remove superfluous newline at tftp help text Michael Walle
2025-03-12 7:42 ` Michael Walle
@ 2025-03-12 8:26 ` Jerome Forissier
1 sibling, 0 replies; 3+ messages in thread
From: Jerome Forissier @ 2025-03-12 8:26 UTC (permalink / raw)
To: Michael Walle, Tom Rini; +Cc: u-boot
On 3/12/25 08:37, Michael Walle wrote:
> The help text has a newline at the end which will lead to an empty
> line after the tftpboot when printing the help overview. Remove it.
>
> Fixes: 4d4d7838127e ("net: lwip: add TFTP support and tftpboot command")
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
> cmd/net-lwip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/net-lwip.c b/cmd/net-lwip.c
> index 0fd446ecb20..249556243d6 100644
> --- a/cmd/net-lwip.c
> +++ b/cmd/net-lwip.c
> @@ -17,7 +17,7 @@ U_BOOT_CMD(ping, 2, 1, do_ping, "send ICMP ECHO_REQUEST to network host",
>
> #if defined(CONFIG_CMD_TFTPBOOT)
> U_BOOT_CMD(tftpboot, 3, 0, do_tftpb,
> - "boot image via network using TFTP protocol\n",
> + "boot image via network using TFTP protocol",
> "[loadAddress] [[hostIPaddr:]bootfilename]");
> #endif
>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Thanks,
--
Jerome
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-12 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-12 7:37 [PATCH 2/3] net: lwip: remove superfluous newline at tftp help text Michael Walle
2025-03-12 7:42 ` Michael Walle
2025-03-12 8:26 ` Jerome Forissier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox