Re: [PATCH 0/6] usb: host: ehci-msm: Clean up and fix crashes

[Sam Day <me@samcday.com>]

On Wed Apr 9, 2025 at 7:26 PM CEST, Caleb Connolly wrote:
>
>
> On 4/7/25 11:54, Stephan Gerhold wrote:
>> The ehci-msm driver has several subtle issues and stale code. Most of them
>> are minor and do not cause issues during normal usage. The last patch is
>> the most critical, it fixes a reported crash when stopping/re-configuring
>> USB, which has been around for a few months now.
>>
>> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
>
> Acked-by: Caleb Connolly <caleb.connolly@linaro.org>
>
> I'd appreciate a T-b from Sam or some other MSM8916 device, but this all
> looks good to me!

LGTM - tested on db410c and a samsung-grandprimelte

Tested-by: Sam Day <me@samcday.com>

-Sam

>
> Kind regards,> ---
>> Stephan Gerhold (6):
>>        usb: host: ehci-msm: Fix pointer check
>>        usb: host: echi-msm: Drop ulpi definitions
>>        usb: host: ehci-msm: Disable clocks after all register accesses
>>        usb: host: ehci-msm: Use clk bulk helpers
>>        usb: host: ehci-msm: Drop redundant EHCI register writes
>>        usb: host: ehci-msm: Register ULPI PHY through NOP wrapper
>>
>>   drivers/usb/host/ehci-msm.c | 146 ++++++++++++++++++++------------------------
>>   1 file changed, 67 insertions(+), 79 deletions(-)
>> ---
>> base-commit: 0efe8ea57fc7a1a6fc5f64fb3cf6bc4a1a4fc219
>> change-id: 20250121-ehci-msm-fixes-b1ed17a1eaea
>>
>> Best regards,
> --
> Caleb (they/them)