From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Marek Vasut <marex@denx.de>
Cc: Sumit Garg <sumit.garg@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Tom Rini <trini@konsulko.com>,
Jianfeng Zhu <JianfengA.Zhu@sony.com>,
Jacky Cao <Jacky.Cao@sony.com>, Sam Day <me@samcday.com>,
u-boot-qcom@groups.io, u-boot@lists.denx.de,
Casey Connolly <casey.connolly@linaro.org>
Subject: Re: [PATCH 0/6] usb: host: ehci-msm: Clean up and fix crashes
Date: Mon, 8 Sep 2025 13:39:44 +0200 [thread overview]
Message-ID: <aL7AgBHg6th2w1a5@linaro.org> (raw)
In-Reply-To: <20250407-ehci-msm-fixes-v1-0-f8b30eb05d07@linaro.org>
Hi Marek,
On Mon, Apr 07, 2025 at 11:54:20AM +0200, Stephan Gerhold wrote:
> The ehci-msm driver has several subtle issues and stale code. Most of them
> are minor and do not cause issues during normal usage. The last patch is
> the most critical, it fixes a reported crash when stopping/re-configuring
> USB, which has been around for a few months now.
>
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
> Stephan Gerhold (6):
> usb: host: ehci-msm: Fix pointer check
> usb: host: echi-msm: Drop ulpi definitions
> usb: host: ehci-msm: Disable clocks after all register accesses
> usb: host: ehci-msm: Use clk bulk helpers
> usb: host: ehci-msm: Drop redundant EHCI register writes
> usb: host: ehci-msm: Register ULPI PHY through NOP wrapper
>
> drivers/usb/host/ehci-msm.c | 146 ++++++++++++++++++++------------------------
> 1 file changed, 67 insertions(+), 79 deletions(-)
Could you apply these patches and send them to Tom? These are important
fixes to make USB work properly on the dragonboard410c board and they
have been on the list for a few months now. There is already an ack from
Casey as well.
Or would it be easier for you if Casey applies them? I'm sure that would
work too. :)
Thanks,
Stephan
next prev parent reply other threads:[~2025-09-08 11:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 9:54 [PATCH 0/6] usb: host: ehci-msm: Clean up and fix crashes Stephan Gerhold
2025-04-07 9:54 ` [PATCH 1/6] usb: host: ehci-msm: Fix pointer check Stephan Gerhold
2025-04-07 9:54 ` [PATCH 2/6] usb: host: echi-msm: Drop ulpi definitions Stephan Gerhold
2025-04-07 9:54 ` [PATCH 3/6] usb: host: ehci-msm: Disable clocks after all register accesses Stephan Gerhold
2025-04-07 9:54 ` [PATCH 4/6] usb: host: ehci-msm: Use clk bulk helpers Stephan Gerhold
2025-04-07 9:54 ` [PATCH 5/6] usb: host: ehci-msm: Drop redundant EHCI register writes Stephan Gerhold
2025-04-07 9:54 ` [PATCH 6/6] usb: host: ehci-msm: Register ULPI PHY through NOP wrapper Stephan Gerhold
2025-04-09 17:26 ` [PATCH 0/6] usb: host: ehci-msm: Clean up and fix crashes Caleb Connolly
2025-04-12 10:20 ` Sam Day
2025-09-08 11:39 ` Stephan Gerhold [this message]
2025-09-08 11:47 ` Marek Vasut
2025-10-30 12:16 ` Casey Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL7AgBHg6th2w1a5@linaro.org \
--to=stephan.gerhold@linaro.org \
--cc=Jacky.Cao@sony.com \
--cc=JianfengA.Zhu@sony.com \
--cc=casey.connolly@linaro.org \
--cc=marex@denx.de \
--cc=me@samcday.com \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox