* [PATCH] tpm: Make U_BOOT_DRIVER entries unique
@ 2025-09-25 20:56 Tom Rini
2025-10-09 6:12 ` Ilias Apalodimas
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rini @ 2025-09-25 20:56 UTC (permalink / raw)
To: u-boot
All instances of the U_BOOT_DRIVER must use a unique name or they will
lead to link time failures due to name space conflicts when both are
present. In this case the driver was reusing the tpm_tis_i2c name.
Signed-off-by: Tom Rini <trini@konsulko.com>
---
drivers/tpm/tpm_tis_infineon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tpm/tpm_tis_infineon.c b/drivers/tpm/tpm_tis_infineon.c
index 30f23f8610a3..c1e7b98295c5 100644
--- a/drivers/tpm/tpm_tis_infineon.c
+++ b/drivers/tpm/tpm_tis_infineon.c
@@ -626,7 +626,7 @@ static const struct udevice_id tpm_tis_i2c_ids[] = {
{ }
};
-U_BOOT_DRIVER(tpm_tis_i2c) = {
+U_BOOT_DRIVER(tpm_tis_infineon) = {
.name = "tpm_tis_infineon",
.id = UCLASS_TPM,
.of_match = tpm_tis_i2c_ids,
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tpm: Make U_BOOT_DRIVER entries unique
2025-09-25 20:56 [PATCH] tpm: Make U_BOOT_DRIVER entries unique Tom Rini
@ 2025-10-09 6:12 ` Ilias Apalodimas
0 siblings, 0 replies; 2+ messages in thread
From: Ilias Apalodimas @ 2025-10-09 6:12 UTC (permalink / raw)
To: Tom Rini, u-boot
Hi Tom,
On Thu Sep 25, 2025 at 11:56 PM EEST, Tom Rini wrote:
> All instances of the U_BOOT_DRIVER must use a unique name or they will
> lead to link time failures due to name space conflicts when both are
> present. In this case the driver was reusing the tpm_tis_i2c name.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> drivers/tpm/tpm_tis_infineon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tpm/tpm_tis_infineon.c b/drivers/tpm/tpm_tis_infineon.c
> index 30f23f8610a3..c1e7b98295c5 100644
> --- a/drivers/tpm/tpm_tis_infineon.c
> +++ b/drivers/tpm/tpm_tis_infineon.c
> @@ -626,7 +626,7 @@ static const struct udevice_id tpm_tis_i2c_ids[] = {
> { }
> };
>
> -U_BOOT_DRIVER(tpm_tis_i2c) = {
> +U_BOOT_DRIVER(tpm_tis_infineon) = {
> .name = "tpm_tis_infineon",
> .id = UCLASS_TPM,
> .of_match = tpm_tis_i2c_ids,
I somehow missed this
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-09 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-25 20:56 [PATCH] tpm: Make U_BOOT_DRIVER entries unique Tom Rini
2025-10-09 6:12 ` Ilias Apalodimas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox