Re: [PATCH V3] arm64: imx: Add support for imx8mp-beacon-kit

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

On Mon, Feb 20, 2023 at 09:50:58AM -0600, Adam Ford wrote:

> Beacon Embedded has an i.MX8M Plus development kit which consists
> of a SOM + baseboard.  The SOM includes Bluetooth, WiFi, QSPI, eMMC,
> and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual
> Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet
> PHY.  The device trees are already queued for inclusion in Linux 6.3.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

In general,

Reviewed-by: Tom Rini <trini@konsulko.com>

And if there's no other feedback, a follow-up patch is fine as this is
likely something to look at on your other platforms too, as further
clean-up work:

> diff --git a/board/beacon/imx8mp/imx8mp_beacon.c b/board/beacon/imx8mp/imx8mp_beacon.c
> new file mode 100644
> index 0000000000..d07d8aa421
> --- /dev/null
> +++ b/board/beacon/imx8mp/imx8mp_beacon.c
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Copyright 2023 Logic PD, Inc dba Beacon EmbeddedWorks */
> +
> +#include <common.h>
> +#include <env.h>
> +#include <errno.h>
> +#include <init.h>
> +#include <miiphy.h>
> +#include <netdev.h>
> +#include <linux/delay.h>
> +#include <asm/global_data.h>
> +#include <asm/mach-imx/iomux-v3.h>
> +#include <asm-generic/gpio.h>
> +#include <asm/arch/imx8mp_pins.h>
> +#include <asm/arch/clock.h>
> +#include <asm/arch/sys_proto.h>
> +#include <asm/mach-imx/gpio.h>

For a small code file, this is a long include list, do we need
everything here, still?

> +DECLARE_GLOBAL_DATA_PTR;

And I don't see anything referring to gd, so I don't think we need this.

> diff --git a/board/beacon/imx8mp/spl.c b/board/beacon/imx8mp/spl.c
> new file mode 100644
> index 0000000000..591e8ca9ab
> --- /dev/null
> +++ b/board/beacon/imx8mp/spl.c
> @@ -0,0 +1,132 @@

Same as the above, here.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]