U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>
Subject: Re: [PATCH v2 2/2] env: mmc: Apply GPT only on eMMC user HW partition
Date: Thu, 9 Feb 2023 10:27:42 -0500	[thread overview]
Message-ID: <Y+UQ7oCHN319gjQR@bill-the-cat> (raw)
In-Reply-To: <20230209123010.31953-2-marex@denx.de>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Thu, Feb 09, 2023 at 01:30:10PM +0100, Marek Vasut wrote:

> Apply the GPT U-Boot environment GUID type look up only on eMMC user
> HW partition, do not apply the look up on eMMC boot HW partitions as
> mmc_offset_try_partition() assumes either SD partitions or eMMC user
> HW partition.
> 
> This fixes environment operation on systems where CONFIG_SYS_MMC_ENV_PART
> is non-zero and CONFIG_SYS_REDUNDAND_ENVIRONMENT is set.
> 
> Fixes: 80105d8fd52 ("env: mmc: select GPT env partition by type guid")
> Signed-off-by: Marek Vasut <marex@denx.de>

So you're saying that today, you cannot make use of this feature and put
the environment on one of the boot partitions, as it doesn't work? If
so, then yes, this is the first step forward and someone else with that
wants the case I described here can fix things further.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2023-02-09 15:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230209123058epcas1p22a2f76f8e2ba8c365886322e217cb453@epcas1p2.samsung.com>
2023-02-09 12:30 ` [PATCH v2 1/2] env: mmc: Clean up macro usage Marek Vasut
2023-02-09 12:30   ` [PATCH v2 2/2] env: mmc: Apply GPT only on eMMC user HW partition Marek Vasut
2023-02-09 15:27     ` Tom Rini [this message]
2023-02-09 16:33       ` Marek Vasut
2023-02-24 14:43     ` Tom Rini
2023-02-09 15:27   ` [PATCH v2 1/2] env: mmc: Clean up macro usage Tom Rini
2023-02-09 20:13     ` Simon Glass
2023-02-10  0:01   ` Jaehoon Chung
2023-02-23 10:41   ` Patrick DELAUNAY
2023-02-23 13:22     ` Marek Vasut
2023-02-23 16:32       ` Tom Rini
2023-02-23 18:24         ` Marek Vasut
2023-02-23 17:17       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+UQ7oCHN319gjQR@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=marex@denx.de \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox