Re: [PATCH v2 2/2] env: mmc: Apply GPT only on eMMC user HW partition

[Marek Vasut <marex@denx.de>]

On 2/9/23 16:27, Tom Rini wrote:
> On Thu, Feb 09, 2023 at 01:30:10PM +0100, Marek Vasut wrote:
> 
>> Apply the GPT U-Boot environment GUID type look up only on eMMC user
>> HW partition, do not apply the look up on eMMC boot HW partitions as
>> mmc_offset_try_partition() assumes either SD partitions or eMMC user
>> HW partition.
>>
>> This fixes environment operation on systems where CONFIG_SYS_MMC_ENV_PART
>> is non-zero and CONFIG_SYS_REDUNDAND_ENVIRONMENT is set.
>>
>> Fixes: 80105d8fd52 ("env: mmc: select GPT env partition by type guid")
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> So you're saying that today, you cannot make use of this feature and put
> the environment on one of the boot partitions, as it doesn't work?

Today you cannot place env into GPT which is located in eMMC BOOT HW 
partitions, that only works for GPT which is located in eMMC USER HW 
partition.

> If
> so, then yes, this is the first step forward and someone else with that
> wants the case I described here can fix things further.

I'm not even sure whether it makes sense to have 4 MiB or so GPT in eMMC 
BOOT HW partitions in the first place, but sure, if someone needs that 
at some later point, why not.

> Reviewed-by: Tom Rini <trini@konsulko.com>