From: John Keeping <john@metanate.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
kever.yang@rock-chips.com, sjg@chromium.org,
philipp.tomsich@vrull.eu, u-boot@lists.denx.de,
Heiko Stuebner <heiko@sntech.de>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4
Date: Tue, 17 Jan 2023 15:20:43 +0000 [thread overview]
Message-ID: <Y8a8ywAzHaUQbQca@donbot> (raw)
In-Reply-To: <a5943bfb-8d7b-6ed4-bbb4-0f018b921564@gmail.com>
Hi Johan,
On Tue, Jan 17, 2023 at 03:44:07PM +0100, Johan Jonker wrote:
> On 1/17/23 10:46, Quentin Schulz wrote:
> > On 1/16/23 20:45, Johan Jonker wrote:
> >> Sync rk3066/rk3188 DT files from Linux.
> >> This is the state as of linux-next v6.2-rc4.
> >> New nfc node for MK808 rk3066a.
> >> CRU nodes now have a clock property.
> >> To prefend dtoc errors a fixed clock must also be
> >> included for tpl/spl in the rk3xxx-u-boot.dtsi file.
> >>
> >> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> >> ---
>
> [..]
>
> >> @@ -223,7 +224,7 @@
> >> #size-cells = <1>;
> >> ranges;
> >>
> >> - gpio0: gpio0@2000a000 {
> >> + gpio0: gpio@2000a000 {
> >> compatible = "rockchip,rk3188-gpio-bank0";
> >> reg = <0x2000a000 0x100>;
> >> interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> >> @@ -236,7 +237,7 @@
> >> #interrupt-cells = <2>;
> >> };
> >>
> >> - gpio1: gpio1@2003c000 {
>
> >> + gpio1: gpio@2003c000 {
>
> Hi,
>
> LOL: I made that binding change on request from Linux DT maintainers.
> Node names should generic.
>
> ===
>
> My full u-boot is able to boot a Linux kernel for rk3066a.
> Only when I give the command below it crashes:
>
> gpio status -a
>
> Could you confirm what other parts are effected?
>
> If it's boots then it's good enough for me and move forward, so please merge.(Kever)
>
> Driver fixes for u-boot depending on Linux DT changes is already very time consuming enough!
This reminded me of a patch that I never followed up with:
https://lore.kernel.org/u-boot/20220726162509.1304234-1-john@metanate.com/
Can you test if that fixes `gpio status -a` for you?
John
next prev parent reply other threads:[~2023-01-17 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 19:45 [PATCH v1] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4 Johan Jonker
2023-01-17 9:46 ` Quentin Schulz
2023-01-17 14:44 ` Johan Jonker
2023-01-17 15:20 ` John Keeping [this message]
2023-01-17 15:58 ` Quentin Schulz
2023-01-17 17:27 ` John Keeping
2023-01-17 20:08 ` Johan Jonker
2023-01-17 16:18 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8a8ywAzHaUQbQca@donbot \
--to=john@metanate.com \
--cc=brgl@bgdev.pl \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox