public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Tom Rini <trini@konsulko.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, u-boot@lists.denx.de
Subject: Re: [PATCH] board: stemmy: Increase boot image to 16 MB
Date: Fri, 19 Nov 2021 21:55:56 +0100	[thread overview]
Message-ID: <YZgPXIw3YHu9Mvv2@gerhold.net> (raw)
In-Reply-To: <20211119181243.GI24579@bill-the-cat>

On Fri, Nov 19, 2021 at 01:12:43PM -0500, Tom Rini wrote:
> On Fri, Nov 19, 2021 at 03:33:21PM +0100, Linus Walleij wrote:
> 
> > When using a recent kernel with a bunch of compiled-in
> > stuff the kernel image easily becomes bigger than 8 MB
> > yielding this error:
> > 
> >   Loading Kernel Image
> >   Image too large: increase CONFIG_SYS_BOOTM_LEN
> >   Must RESET board to recover
> > 
> > Fix this by bumping to SZ_16MB.
> > 
> > Cc: Stephan Gerhold <stephan@gerhold.net>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> >  include/configs/stemmy.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/configs/stemmy.h b/include/configs/stemmy.h
> > index ed79b1203901..f4700a45daf5 100644
> > --- a/include/configs/stemmy.h
> > +++ b/include/configs/stemmy.h
> > @@ -14,6 +14,7 @@
> >   * bootloader. New images are loaded at the same address for compatibility.
> >   */
> >  #define CONFIG_SYS_INIT_SP_ADDR		CONFIG_SYS_TEXT_BASE
> > +#define CONFIG_SYS_BOOTM_LEN		SZ_16M
> >  
> >  /* FIXME: This should be loaded from device tree... */
> >  #define CONFIG_SYS_L2_PL310
> 
> So, the default for CONFIG_SYS_BOOTM_LEN is clearly too small and should
> be addressed broadly.  And, ugh, I don't see a maximum size for the
> kernel itself in
> https://www.kernel.org/doc/Documentation/arm64/booting.rst but SZ_64M is
> the common "we hope this is always large enough" value used, so can we
> push stemmy there as well?  Thanks.
> 

I think there is usually less needed on ARM32 since Linux will
decompress itself, so the size here is actually for the *compressed*
kernel image, not the decompressed one. But it doesn't hurt to have it
larger I guess, so 64 MiB also sounds good to me.

Linus, can you send a v2 with SZ_64M? Also feel free to add my
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

Thanks,
Stephan

      reply	other threads:[~2021-11-19 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 14:33 [PATCH] board: stemmy: Increase boot image to 16 MB Linus Walleij
2021-11-19 18:12 ` Tom Rini
2021-11-19 20:55   ` Stephan Gerhold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZgPXIw3YHu9Mvv2@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=linus.walleij@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox