From: Sumit Garg <sumit.garg@kernel.org>
To: Caleb Connolly <caleb.connolly@linaro.org>
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Tom Rini <trini@konsulko.com>,
u-boot-qcom@groups.io, u-boot@lists.denx.de
Subject: Re: [PATCH] hmibsc_defconfig: disable DM_USB_GADGET
Date: Fri, 4 Apr 2025 11:42:37 +0530 [thread overview]
Message-ID: <Z-94VXb10MM_SV6e@sumit-X1> (raw)
In-Reply-To: <20250402142812.368168-1-caleb.connolly@linaro.org>
On Wed, Apr 02, 2025 at 04:28:03PM +0200, Caleb Connolly wrote:
> As with the db410c this breaks linking as it conflicts with the USB
> controller used by these platforms.
>
> This fixes building after DM_USB_GADGET was enabled by default for
> mach-snapdragon.
>
> Fixes: 7235dbedfce3 (mach-snapdragon: enable DM_USB_GADGET by default)
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> configs/hmibsc_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
-Sumit
> diff --git a/configs/hmibsc_defconfig b/configs/hmibsc_defconfig
> index 88c9c70a6399..4550eba71ab2 100644
> --- a/configs/hmibsc_defconfig
> +++ b/configs/hmibsc_defconfig
> @@ -69,8 +69,9 @@ CONFIG_DM_PMIC=y
> CONFIG_PMIC_QCOM=y
> CONFIG_MSM_SERIAL=y
> CONFIG_SPMI_MSM=y
> CONFIG_USB=y
> +# CONFIG_DM_USB_GADGET is not set
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_EHCI_MSM=y
> CONFIG_USB_ULPI_VIEWPORT=y
> CONFIG_USB_ULPI=y
> --
> 2.48.1
>
next prev parent reply other threads:[~2025-04-04 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 14:28 [PATCH] hmibsc_defconfig: disable DM_USB_GADGET Caleb Connolly
2025-04-04 6:12 ` Sumit Garg [this message]
2025-04-09 17:21 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-94VXb10MM_SV6e@sumit-X1 \
--to=sumit.garg@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=neil.armstrong@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox