U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hmibsc_defconfig: disable DM_USB_GADGET
@ 2025-04-02 14:28 Caleb Connolly
  2025-04-04  6:12 ` Sumit Garg
  2025-04-09 17:21 ` Caleb Connolly
  0 siblings, 2 replies; 3+ messages in thread
From: Caleb Connolly @ 2025-04-02 14:28 UTC (permalink / raw)
  To: Caleb Connolly, Marek Vasut, Neil Armstrong, Sumit Garg, Tom Rini
  Cc: u-boot-qcom, u-boot

As with the db410c this breaks linking as it conflicts with the USB
controller used by these platforms.

This fixes building after DM_USB_GADGET was enabled by default for
mach-snapdragon.

Fixes: 7235dbedfce3 (mach-snapdragon: enable DM_USB_GADGET by default)
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 configs/hmibsc_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/hmibsc_defconfig b/configs/hmibsc_defconfig
index 88c9c70a6399..4550eba71ab2 100644
--- a/configs/hmibsc_defconfig
+++ b/configs/hmibsc_defconfig
@@ -69,8 +69,9 @@ CONFIG_DM_PMIC=y
 CONFIG_PMIC_QCOM=y
 CONFIG_MSM_SERIAL=y
 CONFIG_SPMI_MSM=y
 CONFIG_USB=y
+# CONFIG_DM_USB_GADGET is not set
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_MSM=y
 CONFIG_USB_ULPI_VIEWPORT=y
 CONFIG_USB_ULPI=y
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] hmibsc_defconfig: disable DM_USB_GADGET
  2025-04-02 14:28 [PATCH] hmibsc_defconfig: disable DM_USB_GADGET Caleb Connolly
@ 2025-04-04  6:12 ` Sumit Garg
  2025-04-09 17:21 ` Caleb Connolly
  1 sibling, 0 replies; 3+ messages in thread
From: Sumit Garg @ 2025-04-04  6:12 UTC (permalink / raw)
  To: Caleb Connolly; +Cc: Marek Vasut, Neil Armstrong, Tom Rini, u-boot-qcom, u-boot

On Wed, Apr 02, 2025 at 04:28:03PM +0200, Caleb Connolly wrote:
> As with the db410c this breaks linking as it conflicts with the USB
> controller used by these platforms.
> 
> This fixes building after DM_USB_GADGET was enabled by default for
> mach-snapdragon.
> 
> Fixes: 7235dbedfce3 (mach-snapdragon: enable DM_USB_GADGET by default)
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  configs/hmibsc_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> diff --git a/configs/hmibsc_defconfig b/configs/hmibsc_defconfig
> index 88c9c70a6399..4550eba71ab2 100644
> --- a/configs/hmibsc_defconfig
> +++ b/configs/hmibsc_defconfig
> @@ -69,8 +69,9 @@ CONFIG_DM_PMIC=y
>  CONFIG_PMIC_QCOM=y
>  CONFIG_MSM_SERIAL=y
>  CONFIG_SPMI_MSM=y
>  CONFIG_USB=y
> +# CONFIG_DM_USB_GADGET is not set
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_EHCI_MSM=y
>  CONFIG_USB_ULPI_VIEWPORT=y
>  CONFIG_USB_ULPI=y
> -- 
> 2.48.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hmibsc_defconfig: disable DM_USB_GADGET
  2025-04-02 14:28 [PATCH] hmibsc_defconfig: disable DM_USB_GADGET Caleb Connolly
  2025-04-04  6:12 ` Sumit Garg
@ 2025-04-09 17:21 ` Caleb Connolly
  1 sibling, 0 replies; 3+ messages in thread
From: Caleb Connolly @ 2025-04-09 17:21 UTC (permalink / raw)
  To: Marek Vasut, Neil Armstrong, Sumit Garg, Tom Rini, Caleb Connolly
  Cc: u-boot-qcom, u-boot


On Wed, 02 Apr 2025 16:28:03 +0200, Caleb Connolly wrote:
> As with the db410c this breaks linking as it conflicts with the USB
> controller used by these platforms.
> 
> This fixes building after DM_USB_GADGET was enabled by default for
> mach-snapdragon.
> 
> 
> [...]

Applied, thanks!

[1/1] hmibsc_defconfig: disable DM_USB_GADGET
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/ddbb13b6a4a3

Best regards,
-- 
Caleb Connolly <caleb.connolly@linaro.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-09 17:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-02 14:28 [PATCH] hmibsc_defconfig: disable DM_USB_GADGET Caleb Connolly
2025-04-04  6:12 ` Sumit Garg
2025-04-09 17:21 ` Caleb Connolly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox