U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] configs: enable CONFIG_PCI_REGION_MULTI_ENTRY=y in sifive_unmatched_defconfig
@ 2024-11-19 20:59 Yuri Zaporozhets
  2024-11-27 11:56 ` Leo Liang
  2025-02-21 20:55 ` Yuri Zaporozhets
  0 siblings, 2 replies; 3+ messages in thread
From: Yuri Zaporozhets @ 2024-11-19 20:59 UTC (permalink / raw)
  To: u-boot; +Cc: Yuri Zaporozhets

Currently, the PCI subsystem selects the small "region 2" (which starts at 0x7000000)
as bus_addr/phys_addr. As a consequence, the BAR0 on PCIe video card cannot be initialized,
because it simply doesn't fit into 0x1000000 bytes size of "region 2".

U-Boot should use "region 1" instead (the one which starts at 0x60090000), because
it has much bigger size (0xFF70000), and easily accomodates BAR0 of the video card.
Linux kernel also uses 0x60090000 as bus_start/phys_start.

Signed-off-by: Yuri Zaporozhets <yuriz@vodafonemail.de>
---
 configs/sifive_unmatched_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/sifive_unmatched_defconfig b/configs/sifive_unmatched_defconfig
index 058e5fab68..d5c7d5bfa3 100644
--- a/configs/sifive_unmatched_defconfig
+++ b/configs/sifive_unmatched_defconfig
@@ -36,6 +36,7 @@ CONFIG_DISPLAY_BOARDINFO=y
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_ID_EEPROM=y
 CONFIG_PCI_INIT_R=y
+CONFIG_PCI_REGION_MULTI_ENTRY=y
 CONFIG_SPL_MAX_SIZE=0x100000
 # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
 CONFIG_SPL_SYS_MALLOC=y
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] configs: enable CONFIG_PCI_REGION_MULTI_ENTRY=y in sifive_unmatched_defconfig
  2024-11-19 20:59 [PATCH] configs: enable CONFIG_PCI_REGION_MULTI_ENTRY=y in sifive_unmatched_defconfig Yuri Zaporozhets
@ 2024-11-27 11:56 ` Leo Liang
  2025-02-21 20:55 ` Yuri Zaporozhets
  1 sibling, 0 replies; 3+ messages in thread
From: Leo Liang @ 2024-11-27 11:56 UTC (permalink / raw)
  To: Yuri Zaporozhets; +Cc: u-boot

On Tue, Nov 19, 2024 at 09:59:59PM +0100, Yuri Zaporozhets wrote:
> Currently, the PCI subsystem selects the small "region 2" (which starts at 0x7000000)
> as bus_addr/phys_addr. As a consequence, the BAR0 on PCIe video card cannot be initialized,
> because it simply doesn't fit into 0x1000000 bytes size of "region 2".
> 
> U-Boot should use "region 1" instead (the one which starts at 0x60090000), because
> it has much bigger size (0xFF70000), and easily accomodates BAR0 of the video card.
> Linux kernel also uses 0x60090000 as bus_start/phys_start.
> 
> Signed-off-by: Yuri Zaporozhets <yuriz@vodafonemail.de>
> ---
>  configs/sifive_unmatched_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] configs: enable CONFIG_PCI_REGION_MULTI_ENTRY=y in sifive_unmatched_defconfig
  2024-11-19 20:59 [PATCH] configs: enable CONFIG_PCI_REGION_MULTI_ENTRY=y in sifive_unmatched_defconfig Yuri Zaporozhets
  2024-11-27 11:56 ` Leo Liang
@ 2025-02-21 20:55 ` Yuri Zaporozhets
  1 sibling, 0 replies; 3+ messages in thread
From: Yuri Zaporozhets @ 2025-02-21 20:55 UTC (permalink / raw)
  To: u-boot

Hello,

On Tue, Nov 19, 2024 at 09:59:59PM +0100, Yuri Zaporozhets wrote:

> Currently, the PCI subsystem selects the small "region 2" (which starts at 0x7000000)
> as bus_addr/phys_addr. As a consequence, the BAR0 on PCIe video card cannot be initialized,
> because it simply doesn't fit into 0x1000000 bytes size of "region 2".
> 
> U-Boot should use "region 1" instead (the one which starts at 0x60090000), because
> it has much bigger size (0xFF70000), and easily accomodates BAR0 of the video card.
> Linux kernel also uses 0x60090000 as bus_start/phys_start.
> 
> Signed-off-by: Yuri Zaporozhets <yuriz@vodafonemail.de>
> ---
>  configs/sifive_unmatched_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/sifive_unmatched_defconfig b/configs/sifive_unmatched_defconfig
> index 058e5fab68..d5c7d5bfa3 100644
> --- a/configs/sifive_unmatched_defconfig
> +++ b/configs/sifive_unmatched_defconfig
> @@ -36,6 +36,7 @@ CONFIG_DISPLAY_BOARDINFO=y
>  CONFIG_DISPLAY_BOARDINFO_LATE=y
>  CONFIG_ID_EEPROM=y
>  CONFIG_PCI_INIT_R=y
> +CONFIG_PCI_REGION_MULTI_ENTRY=y
>  CONFIG_SPL_MAX_SIZE=0x100000
>  # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
>  CONFIG_SPL_SYS_MALLOC=y
> -- 
> 2.39.5
>

This is reviewed by Leo Yu-Chi Liang. Could you please apply? Thanks!

-- 
Regards,
Yuri

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-22  5:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-19 20:59 [PATCH] configs: enable CONFIG_PCI_REGION_MULTI_ENTRY=y in sifive_unmatched_defconfig Yuri Zaporozhets
2024-11-27 11:56 ` Leo Liang
2025-02-21 20:55 ` Yuri Zaporozhets

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox