[PATCH 2/3] riscv: qemu: Enable EFI framebuffer

[PATCH 2/3] riscv: qemu: Enable EFI framebuffer

[lekkit]

From: LekKit <50500857+LekKit@users.noreply.github.com>

Enable framebuffer for better virtual machine integration.
Some guests need EFI FB to work properly.
---
 board/emulation/qemu-riscv/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
index 9538c66e..012ac14a 100644
--- a/board/emulation/qemu-riscv/Kconfig
+++ b/board/emulation/qemu-riscv/Kconfig
@@ -58,6 +58,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply E1000
 	imply PCI
 	imply NVME_PCI
+	imply VIDEO
+	imply VIDEO_SIMPLE
 	imply PCIE_ECAM_GENERIC
 	imply DM_RNG
 	imply DM_RTC
-- 
2.46.0

[PATCH 3/3] riscv: qemu: Explicitly advertise RVVM support

[lekkit]

From: LekKit <50500857+LekKit@users.noreply.github.com>

This patch series enables full RVVM virtual machine support which was
earlier inconveniently provided as out-of-tree patchset.

This should be cleaner than a separate board config, since both
emulators provide similar feature set.
---
 arch/riscv/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index fa3b016c..7c52e666 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -21,7 +21,7 @@ config TARGET_OPENPITON_RISCV64
 	bool "Support RISC-V cores on OpenPiton SoC"
 
 config TARGET_QEMU_VIRT
-	bool "Support QEMU Virt Board"
+	bool "Support QEMU Virt & RVVM Boards"
 	select BOARD_LATE_INIT
 
 config TARGET_SIFIVE_UNLEASHED
-- 
2.46.0

Re: [PATCH 2/3] riscv: qemu: Enable EFI framebuffer

[Leo Liang]

On Sun, Sep 22, 2024 at 01:11:01PM +0300, lekkit@at.encryp.ch wrote:
> [EXTERNAL MAIL]
> 
> From: LekKit <50500857+LekKit@users.noreply.github.com>
> 
> Enable framebuffer for better virtual machine integration.
> Some guests need EFI FB to work properly.
> ---
>  board/emulation/qemu-riscv/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>

Re: [PATCH 3/3] riscv: qemu: Explicitly advertise RVVM support

[Leo Liang]

On Sun, Sep 22, 2024 at 01:11:02PM +0300, lekkit@at.encryp.ch wrote:
> [EXTERNAL MAIL]
> 
> From: LekKit <50500857+LekKit@users.noreply.github.com>
> 
> This patch series enables full RVVM virtual machine support which was
> earlier inconveniently provided as out-of-tree patchset.
> 
> This should be cleaner than a separate board config, since both
> emulators provide similar feature set.
> ---
>  arch/riscv/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>

Re: [PATCH 2/3] riscv: qemu: Enable EFI framebuffer

[Leo Liang]

Hi Lekkit,

On Sun, Sep 22, 2024 at 01:11:01PM +0300, lekkit@at.encryp.ch wrote:
> [EXTERNAL MAIL]
> 
> From: LekKit <50500857+LekKit@users.noreply.github.com>
> 
> Enable framebuffer for better virtual machine integration.
> Some guests need EFI FB to work properly.
> ---
>  board/emulation/qemu-riscv/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
> index 9538c66e..012ac14a 100644
> --- a/board/emulation/qemu-riscv/Kconfig
> +++ b/board/emulation/qemu-riscv/Kconfig
> @@ -58,6 +58,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>         imply E1000
>         imply PCI
>         imply NVME_PCI
> +       imply VIDEO
> +       imply VIDEO_SIMPLE

Enabling simplefb driver generates the following compile warning for 32 bit environment.
Could you take a look and fix that?

drivers/video/simplefb.c: In function 'simple_video_probe':
drivers/video/simplefb.c:30:15: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'fdt_addr_t' {aka 'unsigned int'} [-Wformat=]
   30 |         debug("%s: base=%llx, size=%llu\n", __func__, base, size);
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


drivers/video/simplefb.c:30:28: note: format string is defined here
   30 |         debug("%s: base=%llx, size=%llu\n", __func__, base, size);
      |                         ~~~^
      |                            |
      |                            long long unsigned int


Best regards,
Leo

>         imply PCIE_ECAM_GENERIC
>         imply DM_RNG
>         imply DM_RTC
> --
> 2.46.0
>