* [PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV
@ 2024-10-19 8:31 Heinrich Schuchardt
2024-10-19 10:50 ` E Shattow
2024-10-28 7:33 ` Leo Liang
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2024-10-19 8:31 UTC (permalink / raw)
To: Minda Chen, Rick Chen, Leo Yu-Chi Liang
Cc: Chanho Park, Nam Cao, Jaehoon Chung, Aurelien Jarno, u-boot,
Heinrich Schuchardt
When moving from vendor U-Boot to the upstream U-Boot it is necessary to
reset the environment.
Provide the 'env erase' sub-command.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
configs/starfive_visionfive2_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
index 511645cebef..c3508926d6c 100644
--- a/configs/starfive_visionfive2_defconfig
+++ b/configs/starfive_visionfive2_defconfig
@@ -62,6 +62,7 @@ CONFIG_SPL_DM_RESET=y
CONFIG_SPL_SPI_LOAD=y
CONFIG_SPL_YMODEM_SUPPORT=y
CONFIG_SYS_PROMPT="StarFive # "
+CONFIG_CMD_ERASEENV=y
CONFIG_CMD_EEPROM=y
CONFIG_SYS_EEPROM_SIZE=512
CONFIG_SYS_EEPROM_PAGE_WRITE_BITS=4
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV
2024-10-19 8:31 [PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV Heinrich Schuchardt
@ 2024-10-19 10:50 ` E Shattow
2024-10-28 7:33 ` Leo Liang
1 sibling, 0 replies; 3+ messages in thread
From: E Shattow @ 2024-10-19 10:50 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Minda Chen, Rick Chen, Leo Yu-Chi Liang, Chanho Park, Nam Cao,
Jaehoon Chung, Aurelien Jarno, u-boot
Hi,
On Sat, Oct 19, 2024 at 1:31 AM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> When moving from vendor U-Boot to the upstream U-Boot it is necessary to
> reset the environment.
>
> Provide the 'env erase' sub-command.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> configs/starfive_visionfive2_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
> index 511645cebef..c3508926d6c 100644
> --- a/configs/starfive_visionfive2_defconfig
> +++ b/configs/starfive_visionfive2_defconfig
> @@ -62,6 +62,7 @@ CONFIG_SPL_DM_RESET=y
> CONFIG_SPL_SPI_LOAD=y
> CONFIG_SPL_YMODEM_SUPPORT=y
> CONFIG_SYS_PROMPT="StarFive # "
> +CONFIG_CMD_ERASEENV=y
> CONFIG_CMD_EEPROM=y
> CONFIG_SYS_EEPROM_SIZE=512
> CONFIG_SYS_EEPROM_PAGE_WRITE_BITS=4
> --
> 2.43.0
>
Looks good to me. I would also enable CMD_NVEDIT_LOAD in combination
with this, for:
env erase; env load; env save
...which is easy to follow for users and works consistently to go from
vendor U-Boot to upstream U-Boot.
-E
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV
2024-10-19 8:31 [PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV Heinrich Schuchardt
2024-10-19 10:50 ` E Shattow
@ 2024-10-28 7:33 ` Leo Liang
1 sibling, 0 replies; 3+ messages in thread
From: Leo Liang @ 2024-10-28 7:33 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Minda Chen, Rick Chen, Chanho Park, Nam Cao, Jaehoon Chung,
Aurelien Jarno, u-boot
On Sat, Oct 19, 2024 at 10:31:09AM +0200, Heinrich Schuchardt wrote:
> When moving from vendor U-Boot to the upstream U-Boot it is necessary to
> reset the environment.
>
> Provide the 'env erase' sub-command.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> configs/starfive_visionfive2_defconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-28 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-19 8:31 [PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV Heinrich Schuchardt
2024-10-19 10:50 ` E Shattow
2024-10-28 7:33 ` Leo Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox