* [PATCH 1/1] riscv: add missing linefeed in error message
@ 2024-10-17 18:16 Heinrich Schuchardt
2024-10-28 7:27 ` Leo Liang
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2024-10-17 18:16 UTC (permalink / raw)
To: Rick Chen, Leo; +Cc: u-boot, Heinrich Schuchardt
* Messages written with log_err() should be terminated with linefeed.
* Spell device-tree with hyphen as elsewhere in U-Boot.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
arch/riscv/lib/fdt_fixup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/lib/fdt_fixup.c b/arch/riscv/lib/fdt_fixup.c
index c658e72bd39..3a3a3f9e9f0 100644
--- a/arch/riscv/lib/fdt_fixup.c
+++ b/arch/riscv/lib/fdt_fixup.c
@@ -142,7 +142,7 @@ int arch_fixup_fdt(void *blob)
size = fdt_totalsize(blob);
err = fdt_open_into(blob, blob, size + 32);
if (err < 0) {
- log_err("Device Tree can't be expanded to accommodate new node");
+ log_err("Device-tree can't be expanded to accommodate new node\n");
return err;
}
chosen_offset = fdt_path_offset(blob, "/chosen");
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] riscv: add missing linefeed in error message
2024-10-17 18:16 [PATCH 1/1] riscv: add missing linefeed in error message Heinrich Schuchardt
@ 2024-10-28 7:27 ` Leo Liang
0 siblings, 0 replies; 2+ messages in thread
From: Leo Liang @ 2024-10-28 7:27 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Rick Chen, u-boot
On Thu, Oct 17, 2024 at 08:16:49PM +0200, Heinrich Schuchardt wrote:
> * Messages written with log_err() should be terminated with linefeed.
> * Spell device-tree with hyphen as elsewhere in U-Boot.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> arch/riscv/lib/fdt_fixup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-28 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-17 18:16 [PATCH 1/1] riscv: add missing linefeed in error message Heinrich Schuchardt
2024-10-28 7:27 ` Leo Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox