Re: [PATCH v2] gpio: aspeed: port Linux dt-bindings header file

[Dhananjay Phadke <dphadke@linux.microsoft.com>]

On 8/3/2022 7:35 PM, Joel Stanley wrote:
> On Thu, 4 Aug 2022 at 01:02, Dhananjay Phadke
> <dphadke@linux.microsoft.com> wrote:
>>
>> Ported as is, makes it easier to add readable GPIO definitions
>> in DTS files.
>>
>> Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
>> ---
>>   include/dt-bindings/gpio/aspeed-gpio.h | 49 ++++++++++++++++++++++++++
>>   1 file changed, 49 insertions(+)
>>   create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h
>>
>> diff --git a/include/dt-bindings/gpio/aspeed-gpio.h b/include/dt-bindings/gpio/aspeed-gpio.h
>> new file mode 100644
>> index 0000000000..adab2f56c2
>> --- /dev/null
>> +++ b/include/dt-bindings/gpio/aspeed-gpio.h
>> @@ -0,0 +1,49 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
> 
> As you mention this is from the kernel, but you forgot to add the
> copyright information for the file you copied. I suggest you add:
> 
> Copyright 2022 IBM Corp.

It would have been nicer to assert copyrights in kernel source itself,
so that it would have been inherited instead of inserting here.

For now, will send v3 with just that.

Thanks,
Dhananjay