From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: Re: [PATCH 7/9] arm: mvebu: axp: Remove unreferenced ddr3_get_eprom_fabric() function
Date: Sat, 18 Dec 2021 14:44:34 +0100 [thread overview]
Message-ID: <a82e86bb-a222-e925-c427-2115b8c62836@denx.de> (raw)
In-Reply-To: <20211118081939.861407-7-sr@denx.de>
On 11/18/21 09:19, Stefan Roese wrote:
> This function is not referenced in mainline U-Boot. Let's remove now.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
Applied to u-boot-marvell/next
Thanks,
Stefan
> ---
> drivers/ddr/marvell/axp/ddr3_hw_training.h | 1 -
> drivers/ddr/marvell/axp/ddr3_init.c | 24 ----------------------
> drivers/ddr/marvell/axp/ddr3_init.h | 1 -
> 3 files changed, 26 deletions(-)
>
> diff --git a/drivers/ddr/marvell/axp/ddr3_hw_training.h b/drivers/ddr/marvell/axp/ddr3_hw_training.h
> index 30daaa9831b9..fcdef792c76a 100644
> --- a/drivers/ddr/marvell/axp/ddr3_hw_training.h
> +++ b/drivers/ddr/marvell/axp/ddr3_hw_training.h
> @@ -373,7 +373,6 @@ int ddr3_load_dqs_patterns(MV_DRAM_INFO *dram_info);
>
> void ddr3_static_training_init(void);
>
> -u8 ddr3_get_eprom_fabric(void);
> void ddr3_set_performance_params(MV_DRAM_INFO *dram_info);
> int ddr3_dram_sram_burst(u32 src, u32 dst, u32 len);
> void ddr3_save_training(MV_DRAM_INFO *dram_info);
> diff --git a/drivers/ddr/marvell/axp/ddr3_init.c b/drivers/ddr/marvell/axp/ddr3_init.c
> index 607f3e12c3ae..c5aa1ac18f51 100644
> --- a/drivers/ddr/marvell/axp/ddr3_init.c
> +++ b/drivers/ddr/marvell/axp/ddr3_init.c
> @@ -943,30 +943,6 @@ int ddr3_check_config(u32 twsi_addr, MV_CONFIG_TYPE config_type)
> return 0;
> }
>
> -#if defined(DB_88F78X60_REV2)
> -/*
> - * Name: ddr3_get_eprom_fabric - Get Fabric configuration from EPROM
> - * Desc:
> - * Args: twsi Address
> - * Notes: Only Available for ArmadaXP DB Rev2 boards
> - * Returns: None.
> - */
> -u8 ddr3_get_eprom_fabric(void)
> -{
> -#ifdef AUTO_DETECTION_SUPPORT
> - u8 data = 0;
> - int ret;
> -
> - ret = i2c_read(NEW_FABRIC_TWSI_ADDR, 1, 1, (u8 *)&data, 1);
> - if (!ret)
> - return data & 0x1F;
> -#endif
> -
> - return 0;
> -}
> -
> -#endif
> -
> /*
> * Name: ddr3_cl_to_valid_cl - this return register matching CL value
> * Desc:
> diff --git a/drivers/ddr/marvell/axp/ddr3_init.h b/drivers/ddr/marvell/axp/ddr3_init.h
> index 569a14b7184f..9a21886ac3e7 100644
> --- a/drivers/ddr/marvell/axp/ddr3_init.h
> +++ b/drivers/ddr/marvell/axp/ddr3_init.h
> @@ -98,7 +98,6 @@ int ddr3_hw_training(u32 target_freq, u32 ddr_width,
>
> void ddr3_print_version(void);
> void fix_pll_val(u8 target_fab);
> -u8 ddr3_get_eprom_fabric(void);
> u32 ddr3_get_fab_opt(void);
> u32 ddr3_get_cpu_freq(void);
> u32 ddr3_get_vco_freq(void);
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2021-12-18 13:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 8:19 [PATCH 1/9] arm: mvebu: theadorable_debug_defconfig: Enable DM_I2C Stefan Roese
2021-11-18 8:19 ` [PATCH 2/9] arm: mvebu: db-mv784mp-gp_defconfig: " Stefan Roese
2021-12-18 13:43 ` Stefan Roese
2021-11-18 8:19 ` [PATCH 3/9] arm: mvebu: ds414_defconfig: " Stefan Roese
2021-12-18 13:43 ` Stefan Roese
2021-11-18 8:19 ` [PATCH 4/9] arm: mvebu: maxbcm_defconfig: " Stefan Roese
2021-12-18 13:43 ` Stefan Roese
2021-11-18 8:19 ` [PATCH 5/9] arm: mvebu: theadorable: Switch to using DM I2C API Stefan Roese
2021-12-18 13:44 ` Stefan Roese
2021-11-18 8:19 ` [PATCH 6/9] arm: mvebu: axp/high_speed_env_lib: Switch to DM_I2C API Stefan Roese
2021-12-18 13:44 ` Stefan Roese
2021-11-18 8:19 ` [PATCH 7/9] arm: mvebu: axp: Remove unreferenced ddr3_get_eprom_fabric() function Stefan Roese
2021-12-18 13:44 ` Stefan Roese [this message]
2021-11-18 8:19 ` [PATCH 8/9] arm: mvebu: axp: ddr: Switch to using DM I2C API Stefan Roese
2021-12-18 13:44 ` Stefan Roese
2021-11-18 8:19 ` [PATCH 9/9] arm: mvebu: armada-xp-theadorable.dts: Add I2C DT nodes Stefan Roese
2021-12-18 13:45 ` Stefan Roese
2021-12-18 13:43 ` [PATCH 1/9] arm: mvebu: theadorable_debug_defconfig: Enable DM_I2C Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a82e86bb-a222-e925-c427-2115b8c62836@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox