* [PATCH] net: ravb: Remove writeext function call
@ 2020-09-22 6:51 Biju Das
2020-09-22 13:11 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Biju Das @ 2020-09-22 6:51 UTC (permalink / raw)
To: u-boot
The micrel phy driver is already configuring this values from
device tree. So remove the redundant phy configuration call from
this driver.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Tested on RCar M3N board, the final configuration value is same.
rxc-skew-ps 19
ksz90x1_of_config_group Final:1f9
---
drivers/net/ravb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c
index 886f53ee82..98883cd15b 100644
--- a/drivers/net/ravb.c
+++ b/drivers/net/ravb.c
@@ -438,8 +438,6 @@ static int ravb_config(struct udevice *dev)
writel(mask, eth->iobase + RAVB_REG_ECMR);
- phy->drv->writeext(phy, -1, 0x02, 0x08, (0x0f << 5) | 0x19);
-
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] net: ravb: Remove writeext function call
2020-09-22 6:51 [PATCH] net: ravb: Remove writeext function call Biju Das
@ 2020-09-22 13:11 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2020-09-22 13:11 UTC (permalink / raw)
To: u-boot
On 9/22/20 8:51 AM, Biju Das wrote:
> The micrel phy driver is already configuring this values from
> device tree. So remove the redundant phy configuration call from
> this driver.
Applied to sh/next, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-22 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-22 6:51 [PATCH] net: ravb: Remove writeext function call Biju Das
2020-09-22 13:11 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox