From: Sumit Garg <sumit.garg@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Tom Rini <trini@konsulko.com>,
uboot-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 1/9] ARM: dts: stm32h7-pinctrl: add _a suffix to u[s]art_pins phandles
Date: Mon, 9 Jun 2025 14:20:20 +0100 [thread overview]
Message-ID: <aEbflAM3LY5thVwf@sumit-X1> (raw)
In-Reply-To: <20250607093730.2249536-2-dario.binacchi@amarulasolutions.com>
Hi Dario,
On Sat, Jun 07, 2025 at 11:37:09AM +0200, Dario Binacchi wrote:
> Allow expanding possible configurations for the same peripheral,
> consistent with the scheme adopted in Linux.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Link: https://lore.kernel.org/r/20250427074404.3278732-2-dario.binacchi@amarulasolutions.com
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
> [ upstream commit: 6a36dca4375fce51b627f5a985a79fc8b8bd7f55 ]
>
This doesn't show as a proper cherry-pick from devicetree-rebasing tree,
following fails for me:
$ ./tools/update-subtree.sh pick dts 6a36dca4375fce51b627f5a985a79fc8b8bd7f55
From https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing
* branch master -> FETCH_HEAD
fatal: bad object 6a36dca4375fce51b627f5a985a79fc8b8bd7f55
Has this patch landed in Linux mainline?
Ditto for all the subsequent patches in this series.
-Sumit
> ---
>
> dts/upstream/src/arm/st/stm32h7-pinctrl.dtsi | 8 ++++----
> dts/upstream/src/arm/st/stm32h743i-disco.dts | 2 +-
> dts/upstream/src/arm/st/stm32h743i-eval.dts | 2 +-
> dts/upstream/src/arm/st/stm32h750i-art-pi.dts | 6 +++---
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/dts/upstream/src/arm/st/stm32h7-pinctrl.dtsi b/dts/upstream/src/arm/st/stm32h7-pinctrl.dtsi
> index 7f1d234e1024..ad00c1080a96 100644
> --- a/dts/upstream/src/arm/st/stm32h7-pinctrl.dtsi
> +++ b/dts/upstream/src/arm/st/stm32h7-pinctrl.dtsi
> @@ -198,7 +198,7 @@
> };
> };
>
> - uart4_pins: uart4-0 {
> + uart4_pins_a: uart4-0 {
> pins1 {
> pinmux = <STM32_PINMUX('A', 0, AF8)>; /* UART4_TX */
> bias-disable;
> @@ -211,7 +211,7 @@
> };
> };
>
> - usart1_pins: usart1-0 {
> + usart1_pins_a: usart1-0 {
> pins1 {
> pinmux = <STM32_PINMUX('B', 14, AF4)>; /* USART1_TX */
> bias-disable;
> @@ -224,7 +224,7 @@
> };
> };
>
> - usart2_pins: usart2-0 {
> + usart2_pins_a: usart2-0 {
> pins1 {
> pinmux = <STM32_PINMUX('D', 5, AF7)>; /* USART2_TX */
> bias-disable;
> @@ -237,7 +237,7 @@
> };
> };
>
> - usart3_pins: usart3-0 {
> + usart3_pins_a: usart3-0 {
> pins1 {
> pinmux = <STM32_PINMUX('B', 10, AF7)>, /* USART3_TX */
> <STM32_PINMUX('D', 12, AF7)>; /* USART3_RTS_DE */
> diff --git a/dts/upstream/src/arm/st/stm32h743i-disco.dts b/dts/upstream/src/arm/st/stm32h743i-disco.dts
> index 2b452883a708..8451a54a9a08 100644
> --- a/dts/upstream/src/arm/st/stm32h743i-disco.dts
> +++ b/dts/upstream/src/arm/st/stm32h743i-disco.dts
> @@ -105,7 +105,7 @@
> };
>
> &usart2 {
> - pinctrl-0 = <&usart2_pins>;
> + pinctrl-0 = <&usart2_pins_a>;
> pinctrl-names = "default";
> status = "okay";
> };
> diff --git a/dts/upstream/src/arm/st/stm32h743i-eval.dts b/dts/upstream/src/arm/st/stm32h743i-eval.dts
> index 5c5d8059bdc7..4b0ced27b80e 100644
> --- a/dts/upstream/src/arm/st/stm32h743i-eval.dts
> +++ b/dts/upstream/src/arm/st/stm32h743i-eval.dts
> @@ -145,7 +145,7 @@
> };
>
> &usart1 {
> - pinctrl-0 = <&usart1_pins>;
> + pinctrl-0 = <&usart1_pins_a>;
> pinctrl-names = "default";
> status = "okay";
> };
> diff --git a/dts/upstream/src/arm/st/stm32h750i-art-pi.dts b/dts/upstream/src/arm/st/stm32h750i-art-pi.dts
> index 44c307f8b09c..00d195d52a45 100644
> --- a/dts/upstream/src/arm/st/stm32h750i-art-pi.dts
> +++ b/dts/upstream/src/arm/st/stm32h750i-art-pi.dts
> @@ -197,14 +197,14 @@
> };
>
> &usart2 {
> - pinctrl-0 = <&usart2_pins>;
> + pinctrl-0 = <&usart2_pins_a>;
> pinctrl-names = "default";
> status = "disabled";
> };
>
> &usart3 {
> pinctrl-names = "default";
> - pinctrl-0 = <&usart3_pins>;
> + pinctrl-0 = <&usart3_pins_a>;
> dmas = <&dmamux1 45 0x400 0x05>,
> <&dmamux1 46 0x400 0x05>;
> dma-names = "rx", "tx";
> @@ -221,7 +221,7 @@
> };
>
> &uart4 {
> - pinctrl-0 = <&uart4_pins>;
> + pinctrl-0 = <&uart4_pins_a>;
> pinctrl-names = "default";
> status = "okay";
> };
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-06-09 13:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 9:37 [PATCH 0/9] Support stm32h747-discovery board Dario Binacchi
2025-06-07 9:37 ` [PATCH 1/9] ARM: dts: stm32h7-pinctrl: add _a suffix to u[s]art_pins phandles Dario Binacchi
2025-06-09 7:55 ` Patrice CHOTARD
2025-06-09 13:20 ` Sumit Garg [this message]
2025-06-09 13:38 ` Patrice CHOTARD
2025-06-09 13:38 ` Dario Binacchi
2025-06-07 9:37 ` [PATCH 2/9] dt-bindings: arm: stm32: add compatible for stm32h747i-disco board Dario Binacchi
2025-06-09 7:55 ` Patrice CHOTARD
2025-06-07 9:37 ` [PATCH 3/9] dt-bindings: clock: stm32h7: rename USART{7, 8}_CK to UART{7, 8}_CK Dario Binacchi
2025-06-09 7:55 ` [PATCH 3/9] dt-bindings: clock: stm32h7: rename USART{7, 8}_CK to UART{7,8}_CK Patrice CHOTARD
2025-06-07 9:37 ` [PATCH 4/9] ARM: dts: stm32: add uart8 node for stm32h743 MCU Dario Binacchi
2025-06-09 7:56 ` Patrice CHOTARD
2025-06-07 9:37 ` [PATCH 5/9] ARM: dts: stm32: add pin map for UART8 controller on stm32h743 Dario Binacchi
2025-06-09 7:56 ` Patrice CHOTARD
2025-06-07 9:37 ` [PATCH 6/9] ARM: dts: stm32: add an extra pin map for USART1 " Dario Binacchi
2025-06-09 7:56 ` Patrice CHOTARD
2025-06-07 9:37 ` [PATCH 7/9] ARM: dts: stm32: support STM32h747i-disco board Dario Binacchi
2025-06-09 7:57 ` Patrice CHOTARD
2025-06-07 9:37 ` [PATCH 8/9] ARM: dts: stm32: add stm32h747i-disco-u-boot DTS file Dario Binacchi
2025-06-09 7:57 ` Patrice CHOTARD
2025-06-07 9:37 ` [PATCH 9/9] board: stm32: add stm32h747-discovery board support Dario Binacchi
2025-06-09 7:58 ` Patrice CHOTARD
2025-06-09 8:07 ` Lukasz Majewski
2025-06-09 8:34 ` Patrice CHOTARD
2025-06-09 9:22 ` [Uboot-stm32] " Patrice CHOTARD
2025-06-09 9:29 ` Lukasz Majewski
2025-06-09 13:15 ` [PATCH 0/9] Support stm32h747-discovery board Patrice CHOTARD
2025-06-09 13:25 ` Sumit Garg
2025-06-09 13:46 ` Dario Binacchi
2025-06-09 15:40 ` Sumit Garg
2025-06-09 15:50 ` Tom Rini
2025-06-09 16:07 ` Sumit Garg
2025-06-09 16:22 ` Tom Rini
2025-06-10 8:52 ` Sumit Garg
2025-06-10 16:04 ` Tom Rini
2025-06-11 12:08 ` Sumit Garg
2025-06-11 13:25 ` Quentin Schulz
2025-06-11 18:35 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEbflAM3LY5thVwf@sumit-X1 \
--to=sumit.garg@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox