Re: [PATCH 0/9] Support stm32h747-discovery board

[Sumit Garg <sumit.garg@kernel.org>]

On Mon, Jun 09, 2025 at 03:46:27PM +0200, Dario Binacchi wrote:
> Hi Sumit,
> 
> On Mon, Jun 9, 2025 at 3:25 PM Sumit Garg <sumit.garg@kernel.org> wrote:
> >
> > Hi Patrice,
> >
> > On Mon, Jun 09, 2025 at 03:15:14PM +0200, Patrice CHOTARD wrote:
> > >
> > >
> > > On 6/7/25 11:37, Dario Binacchi wrote:
> > > > The series adds support for stm32h747-discovery board.
> > > >
> > > > Detailed information can be found at:
> > > > https://www.st.com/en/evaluation-tools/stm32h747i-disco.html
> > > >
> > > >
> > > > Dario Binacchi (9):
> > > >   ARM: dts: stm32h7-pinctrl: add _a suffix to u[s]art_pins phandles
> > > >   dt-bindings: arm: stm32: add compatible for stm32h747i-disco board
> > > >   dt-bindings: clock: stm32h7: rename USART{7,8}_CK to UART{7,8}_CK
> > > >   ARM: dts: stm32: add uart8 node for stm32h743 MCU
> > > >   ARM: dts: stm32: add pin map for UART8 controller on stm32h743
> > > >   ARM: dts: stm32: add an extra pin map for USART1 on stm32h743
> > > >   ARM: dts: stm32: support STM32h747i-disco board
> > > >   ARM: dts: stm32: add stm32h747i-disco-u-boot DTS file
> > > >   board: stm32: add stm32h747-discovery board support
> > >
> > >
> > > Hi Dario
> > >
> > > For the whole series
> > > Applied to u-boot-stm32/next
> >
> > Please give some time for other maintainers to review this patch-set.
> > The dts/upstream patches in this series aren't clean cherry pick from
> > upstream.
> 
> All the commits are already in the mainline Linux kernel, specifically
> in v6.16-rc1.
> If you're referring to the fact that the patches can't be applied
> cleanly, I believe it's
> because the target path in the Linux kernel doesn't match the one in U-Boot.
> In fact, the DTS files are located in two different relative paths.

That's exactly why we have (refer here [1]):

./tools/update-subtree.sh pick dts <commit-id-to-be-picked>

You should have waited v6.16-rc1 tag to be synced into
devicetree-rebasing [2] for the cherry-picks to work. This way of
manually patching dts/upstream is not allowed since it is going to break
DT syncs in one way or another.

So I would suggest you to wait for v6.16-rc1 to land in DT rebasing tree
and then send v2 with proper cherry picked patches.

[1] https://docs.u-boot.org/en/latest/develop/devicetree/control.html#resyncing-with-devicetree-rebasing
[2] https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git

-Sumit

> 
> Thanks and regards,
> Dario
> 
> > This has to be fixed as otherwise random patches are going to
> > cause DT sync issues.
> >
> > -Sumit
> >
> > >
> > > Thanks
> > > Patrice
> > >
> > > >
> > > >  arch/arm/dts/stm32h747i-disco-u-boot.dtsi     | 104 ++++++++++++++
> > > >  arch/arm/mach-stm32/stm32h7/Kconfig           |   4 +
> > > >  board/st/stm32h747-disco/Kconfig              |  15 ++
> > > >  board/st/stm32h747-disco/MAINTAINERS          |   7 +
> > > >  board/st/stm32h747-disco/Makefile             |   6 +
> > > >  board/st/stm32h747-disco/stm32h747-disco.c    |  42 ++++++
> > > >  configs/stm32h747-disco_defconfig             |  35 +++++
> > > >  drivers/clk/stm32/clk-stm32h7.c               |   5 +
> > > >  dts/upstream/Bindings/arm/stm32/stm32.yaml    |   4 +
> > > >  .../include/dt-bindings/clock/stm32h7-clks.h  |   4 +-
> > > >  dts/upstream/src/arm/st/stm32h7-pinctrl.dtsi  |  34 ++++-
> > > >  dts/upstream/src/arm/st/stm32h743.dtsi        |   8 ++
> > > >  dts/upstream/src/arm/st/stm32h743i-disco.dts  |   2 +-
> > > >  dts/upstream/src/arm/st/stm32h743i-eval.dts   |   2 +-
> > > >  dts/upstream/src/arm/st/stm32h747i-disco.dts  | 136 ++++++++++++++++++
> > > >  dts/upstream/src/arm/st/stm32h750i-art-pi.dts |   6 +-
> > > >  include/configs/stm32h747-disco.h             |  32 +++++
> > > >  17 files changed, 435 insertions(+), 11 deletions(-)
> > > >  create mode 100644 arch/arm/dts/stm32h747i-disco-u-boot.dtsi
> > > >  create mode 100644 board/st/stm32h747-disco/Kconfig
> > > >  create mode 100644 board/st/stm32h747-disco/MAINTAINERS
> > > >  create mode 100644 board/st/stm32h747-disco/Makefile
> > > >  create mode 100644 board/st/stm32h747-disco/stm32h747-disco.c
> > > >  create mode 100644 configs/stm32h747-disco_defconfig
> > > >  create mode 100644 dts/upstream/src/arm/st/stm32h747i-disco.dts
> > > >  create mode 100644 include/configs/stm32h747-disco.h
> > > >
> 
> 
> 
> -- 
> 
> Dario Binacchi
> 
> Senior Embedded Linux Developer
> 
> dario.binacchi@amarulasolutions.com
> 
> __________________________________
> 
> 
> Amarula Solutions SRL
> 
> Via Le Canevare 30, 31100 Treviso, Veneto, IT
> 
> T. +39 042 243 5310
> info@amarulasolutions.com
> 
> www.amarulasolutions.com