[PATCH] phy: qcom: Fix ret is uninitialised

[PATCH] phy: qcom: Fix ret is uninitialised

[Andrew Goodbody]

In qcom_snps_eusb2_phy_probe after the call to devm_clk_get if an error
is found then ret is printed but has not been assigned to by the code.
Decode the error from the pointer and assign it to ret.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---
 drivers/phy/qcom/phy-qcom-snps-eusb2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/qcom/phy-qcom-snps-eusb2.c b/drivers/phy/qcom/phy-qcom-snps-eusb2.c
index b2655ac007c..28502c46f67 100644
--- a/drivers/phy/qcom/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qcom/phy-qcom-snps-eusb2.c
@@ -331,8 +331,9 @@ static int qcom_snps_eusb2_phy_probe(struct udevice *dev)
 
 	qcom_snps_eusb2->ref_clk = devm_clk_get(dev, "ref");
 	if (IS_ERR(qcom_snps_eusb2->ref_clk)) {
+		ret = PTR_ERR(qcom_snps_eusb2->ref_clk);
 		printf("%s: failed to get ref clk %d\n", __func__, ret);
-		return PTR_ERR(qcom_snps_eusb2->ref_clk);
+		return ret;
 	}
 
 	ret = reset_get_bulk(dev, &qcom_snps_eusb2->resets);

---
base-commit: 007610da2cca405ea7739fc120d90085be4b6ac2
change-id: 20250806-phy_qcom_snps-3134f2c95276

Best regards,
-- 
Andrew Goodbody <andrew.goodbody@linaro.org>

Re: [PATCH] phy: qcom: Fix ret is uninitialised

[Sumit Garg]

On Wed, Aug 06, 2025 at 05:55:04PM +0100, Andrew Goodbody wrote:
> In qcom_snps_eusb2_phy_probe after the call to devm_clk_get if an error
> is found then ret is printed but has not been assigned to by the code.
> Decode the error from the pointer and assign it to ret.
> 
> This issue was found by Smatch.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
> ---
>  drivers/phy/qcom/phy-qcom-snps-eusb2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> diff --git a/drivers/phy/qcom/phy-qcom-snps-eusb2.c b/drivers/phy/qcom/phy-qcom-snps-eusb2.c
> index b2655ac007c..28502c46f67 100644
> --- a/drivers/phy/qcom/phy-qcom-snps-eusb2.c
> +++ b/drivers/phy/qcom/phy-qcom-snps-eusb2.c
> @@ -331,8 +331,9 @@ static int qcom_snps_eusb2_phy_probe(struct udevice *dev)
>  
>  	qcom_snps_eusb2->ref_clk = devm_clk_get(dev, "ref");
>  	if (IS_ERR(qcom_snps_eusb2->ref_clk)) {
> +		ret = PTR_ERR(qcom_snps_eusb2->ref_clk);
>  		printf("%s: failed to get ref clk %d\n", __func__, ret);
> -		return PTR_ERR(qcom_snps_eusb2->ref_clk);
> +		return ret;
>  	}
>  
>  	ret = reset_get_bulk(dev, &qcom_snps_eusb2->resets);
> 
> ---
> base-commit: 007610da2cca405ea7739fc120d90085be4b6ac2
> change-id: 20250806-phy_qcom_snps-3134f2c95276
> 
> Best regards,
> -- 
> Andrew Goodbody <andrew.goodbody@linaro.org>
> 

Re: [PATCH] phy: qcom: Fix ret is uninitialised

[Casey Connolly]

On Wed, 06 Aug 2025 17:55:04 +0100, Andrew Goodbody wrote:
> In qcom_snps_eusb2_phy_probe after the call to devm_clk_get if an error
> is found then ret is printed but has not been assigned to by the code.
> Decode the error from the pointer and assign it to ret.
> 
> This issue was found by Smatch.
> 
> 
> [...]

Applied, thanks!

[1/1] phy: qcom: Fix ret is uninitialised
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/fda7bee6468e

Best regards,
-- 
// Caleb (they/them)