From: Yao Zi <ziyao@disroot.org>
To: Uros Stajic <uros.stajic@htecgroup.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: Djordje Todorovic <Djordje.Todorovic@htecgroup.com>,
Chao-ying Fu <cfu@mips.com>
Subject: Re: [PATCH v4 09/10] riscv: boston: Add support for LED character display command
Date: Thu, 9 Oct 2025 11:15:57 +0000 [thread overview]
Message-ID: <aOeZbQ_Ew64f1ohn@pie> (raw)
In-Reply-To: <20250819103021.1518687-10-uros.stajic@htecgroup.com>
On Tue, Aug 19, 2025 at 10:34:01AM +0000, Uros Stajic wrote:
> From: Chao-ying Fu <cfu@mips.com>
>
> Add basic support for the 8-char LED display on P8700-based Boston
> Board using display_set() and display_putc(), enabling the generic
> 'display' command with clear and home support.
I noticed the similar "display" command has been removed back to 2019
in commit 005a804d0f3 (cmd: remove unused `display` command,
2019-05-21).
To me, It doesn't seem a good idea to add it back, at least more
discussion is necessary for it.
Could the driver be implemented as a stdio device instead? And could it
be described in devicetree to avoid non-DM code as much as possible?
Regards,
Yao Zi
> Signed-off-by: Chao-ying Fu <cfu@mips.com>
> Signed-off-by: Uros Stajic <uros.stajic@htecgroup.com>
> ---
> board/mips/boston-riscv/Kconfig | 4 ++
> board/mips/boston-riscv/MAINTAINERS | 3 ++
> board/mips/boston-riscv/Makefile | 1 +
> board/mips/boston-riscv/display.c | 33 ++++++++++++++++
> board/mips/boston-riscv/lowlevel_init.S | 2 +
> cmd/Kconfig | 8 ++++
> cmd/Makefile | 1 +
> cmd/display.c | 51 +++++++++++++++++++++++++
> doc/README.LED_display | 26 +++++++++++++
> include/led-display.h | 33 ++++++++++++++++
> 10 files changed, 162 insertions(+)
> create mode 100644 board/mips/boston-riscv/display.c
> create mode 100644 cmd/display.c
> create mode 100644 doc/README.LED_display
> create mode 100644 include/led-display.h
next prev parent reply other threads:[~2025-10-09 11:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 10:31 [PATCH v4 00/10] riscv: Add support for P8700 platform on Boston board Uros Stajic
2025-08-19 10:31 ` [PATCH v4 01/10] riscv: Add initial support for P8700 SoC Uros Stajic
2025-10-09 10:23 ` Yao Zi
2026-01-13 7:12 ` Uros Stajic
2025-08-19 10:32 ` [PATCH v4 02/10] board: boston-riscv: Add initial support for P8700 Boston board Uros Stajic
2025-10-09 10:46 ` Yao Zi
2025-08-19 10:32 ` [PATCH v4 03/10] gpio: Add GPIO driver for Intel EG20T Uros Stajic
2025-08-19 10:32 ` [PATCH v4 04/10] pci: xilinx: Avoid writing memory base/limit for root bridge Uros Stajic
2025-08-19 10:32 ` [PATCH v4 05/10] riscv: Add support for MIPS GIC syscon on RISC-V SoCs Uros Stajic
2025-10-09 10:53 ` Yao Zi
2025-08-19 10:33 ` [PATCH v4 06/10] net: pch_gbe: Add PHY reset and MAC address fallback for RISC-V Uros Stajic
2025-08-19 10:33 ` [PATCH v4 07/10] libfdt: Allow non-64b aligned memreserve entries Uros Stajic
2025-08-19 10:33 ` [PATCH v4 08/10] riscv: p8700: Add Coherence Manager (CM) and IOCU support Uros Stajic
2025-08-19 10:34 ` [PATCH v4 09/10] riscv: boston: Add support for LED character display command Uros Stajic
2025-10-09 11:15 ` Yao Zi [this message]
2026-01-13 8:19 ` Uros Stajic
2025-08-19 10:34 ` [PATCH v4 10/10] cmd: riscv: Add 'startharts' command to start multiple harts Uros Stajic
2025-10-09 11:43 ` Yao Zi
2026-01-13 8:20 ` Uros Stajic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOeZbQ_Ew64f1ohn@pie \
--to=ziyao@disroot.org \
--cc=Djordje.Todorovic@htecgroup.com \
--cc=cfu@mips.com \
--cc=u-boot@lists.denx.de \
--cc=uros.stajic@htecgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox