U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Valla <francesco@valla.it>
To: Javier Viguera <javier.viguera@digi.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>, Ye Li <ye.li@nxp.com>,
	Peng Fan <peng.fan@nxp.com>,
	u-boot@lists.denx.de, Stefano Babic <sbabic@nabladev.com>,
	Tom Rini <trini@konsulko.com>,
	Sumit Garg <sumit.garg@oss.qualcomm.com>
Subject: Re: [PATCH] imx91: fix ENET1_TD3 pinmux for GPIO function
Date: Thu, 13 Nov 2025 15:39:16 +0100	[thread overview]
Message-ID: <aRXtlIBXvl-nBriQ@bywater> (raw)
In-Reply-To: <dff97ea3-5b81-4624-b120-ba43da8b280c@digi.com>

Hi,

On Thu, Nov 13, 2025 at 02:33:05PM +0100, Javier Viguera wrote:
> On 12/11/25 22:15, Fabio Estevam wrote:
> > Hi Francesco,
> > 
> > On Tue, Nov 11, 2025 at 10:19 AM Francesco Valla <francesco@valla.it> wrote:
> > > 
> > > Fix a typo in the GPIO function for the ENET1_TD3 pad, aligning it to
> > > the function specified in the datasheet.
> > > 
> > > Fixes: a9d562daa3c3 ("imx: Add iMX91 support")
> > > 
> > > Signed-off-by: Francesco Valla <francesco@valla.it>
> > 
> > Nice catch!
> > 
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > 
> 
> Just for completeness, I think there is another one:
> MX91_PAD_I2C2_SCL__GPIO1_IO3 should e MX91_PAD_I2C2_SCL__GPIO1_IO2
> 

Another nice catch. I'll send an updated patch with this fix too (and
your R-b tag).

Thank you

> --
> Regards
> Javier Viguera
> Digi International Inc.
> 
>

Regards,
Francesco


      reply	other threads:[~2025-11-13 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-11 13:18 [PATCH] imx91: fix ENET1_TD3 pinmux for GPIO function Francesco Valla
2025-11-12 21:15 ` Fabio Estevam
2025-11-13 13:33   ` Javier Viguera
2025-11-13 14:39     ` Francesco Valla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRXtlIBXvl-nBriQ@bywater \
    --to=francesco@valla.it \
    --cc=festevam@gmail.com \
    --cc=javier.viguera@digi.com \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@nabladev.com \
    --cc=sumit.garg@oss.qualcomm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox