[PATCH] imx91: fix ENET1_TD3 pinmux for GPIO function

[PATCH] imx91: fix ENET1_TD3 pinmux for GPIO function

[Francesco Valla]

Fix a typo in the GPIO function for the ENET1_TD3 pad, aligning it to
the function specified in the datasheet.

Fixes: a9d562daa3c3 ("imx: Add iMX91 support")

Signed-off-by: Francesco Valla <francesco@valla.it>
---
 arch/arm/dts/imx91-11x11-evk.dts            | 2 +-
 arch/arm/dts/imx91-pinfunc.h                | 2 +-
 arch/arm/include/asm/arch-imx9/imx91_pins.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/imx91-11x11-evk.dts b/arch/arm/dts/imx91-11x11-evk.dts
index 65571fc223b779d5aafc87da3940624db32418cf..ca9070a4c76440e72ecb2534ab55596fecb758d5 100644
--- a/arch/arm/dts/imx91-11x11-evk.dts
+++ b/arch/arm/dts/imx91-11x11-evk.dts
@@ -503,7 +503,7 @@
 			MX91_PAD_ENET1_TD0__GPIO4_IO5                          0x31e
 			MX91_PAD_ENET1_TD1__GPIO4_IO4                          0x31e
 			MX91_PAD_ENET1_TD2__GPIO4_IO3				0x31e
-			MX91_PAD_ENET1_TD3__GPIO4_IO3				0x31e
+			MX91_PAD_ENET1_TD3__GPIO4_IO2				0x31e
 			MX91_PAD_ENET1_TXC__GPIO4_IO7                          0x31e
 			MX91_PAD_ENET1_TX_CTL__GPIO4_IO6                       0x31e
 		>;
diff --git a/arch/arm/dts/imx91-pinfunc.h b/arch/arm/dts/imx91-pinfunc.h
index b0066df173b1386f040b0776fd798406a6e39e06..1e15a0cacf8a8f83ad1e7d602c24cb622f94f078 100644
--- a/arch/arm/dts/imx91-pinfunc.h
+++ b/arch/arm/dts/imx91-pinfunc.h
@@ -330,7 +330,7 @@
 #define MX91_PAD_ENET1_TD3__CAN2_TX                                              0x00a0 0x0250 0x0000 0x02 0x00
 #define MX91_PAD_ENET1_TD3__HSIOMIX_OTG_ID2                                      0x00a0 0x0250 0x0000 0x03 0x00
 #define MX91_PAD_ENET1_TD3__FLEXIO2_FLEXIO2                                      0x00a0 0x0250 0x0000 0x04 0x00
-#define MX91_PAD_ENET1_TD3__GPIO4_IO3                                            0x00a0 0x0250 0x0000 0x05 0x00
+#define MX91_PAD_ENET1_TD3__GPIO4_IO2                                            0x00a0 0x0250 0x0000 0x05 0x00
 #define MX91_PAD_ENET1_TD3__LPI2C2_SCL                                           0x00a0 0x0250 0x03e8 0x06 0x00
 
 #define MX91_PAD_ENET1_TD2__ENET_QOS_RGMII_TD2                                   0x00a4 0x0254 0x0000 0x00 0x00
diff --git a/arch/arm/include/asm/arch-imx9/imx91_pins.h b/arch/arm/include/asm/arch-imx9/imx91_pins.h
index 26246702a9607cd1ba6c8a15be9313db63b2a4af..64bc4de4b2b0964cac56ddff372baa2b389750da 100644
--- a/arch/arm/include/asm/arch-imx9/imx91_pins.h
+++ b/arch/arm/include/asm/arch-imx9/imx91_pins.h
@@ -329,7 +329,7 @@ enum {
 	MX91_PAD_ENET1_TD3__CAN2_TX                                                     = IOMUX_PAD(0x0250, 0x00A0, 0x02, 0x0000, 0x00, 0x00),
 	MX91_PAD_ENET1_TD3__HSIOMIX_OTG_ID2                                             = IOMUX_PAD(0x0250, 0x00A0, 0x03, 0x0000, 0x00, 0x00),
 	MX91_PAD_ENET1_TD3__FLEXIO2_FLEXIO2                                             = IOMUX_PAD(0x0250, 0x00A0, 0x04, 0x0000, 0x00, 0x00),
-	MX91_PAD_ENET1_TD3__GPIO4_IO3                                                   = IOMUX_PAD(0x0250, 0x00A0, 0x05, 0x0000, 0x00, 0x00),
+	MX91_PAD_ENET1_TD3__GPIO4_IO2                                                   = IOMUX_PAD(0x0250, 0x00A0, 0x05, 0x0000, 0x00, 0x00),
 	MX91_PAD_ENET1_TD3__LPI2C2_SCL                                                  = IOMUX_PAD(0x0250, 0x00A0, 0x06, 0x03E8, 0x00, 0x00),
 
 	MX91_PAD_ENET1_TD2__ENET_QOS_RGMII_TD2                                          = IOMUX_PAD(0x0254, 0x00A4, 0x00, 0x0000, 0x00, 0x00),

---
base-commit: 365a7079fb918643da0f0709660a7d8ea76dd6f3
change-id: 20251111-imx91_pins_fix-6bfae694156c

Best regards,
-- 
Francesco Valla <francesco@valla.it>

Re: [PATCH] imx91: fix ENET1_TD3 pinmux for GPIO function

[Fabio Estevam]

Hi Francesco,

On Tue, Nov 11, 2025 at 10:19 AM Francesco Valla <francesco@valla.it> wrote:
>
> Fix a typo in the GPIO function for the ENET1_TD3 pad, aligning it to
> the function specified in the datasheet.
>
> Fixes: a9d562daa3c3 ("imx: Add iMX91 support")
>
> Signed-off-by: Francesco Valla <francesco@valla.it>

Nice catch!

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Re: [PATCH] imx91: fix ENET1_TD3 pinmux for GPIO function

[Javier Viguera]

On 12/11/25 22:15, Fabio Estevam wrote:
> Hi Francesco,
> 
> On Tue, Nov 11, 2025 at 10:19 AM Francesco Valla <francesco@valla.it> wrote:
>>
>> Fix a typo in the GPIO function for the ENET1_TD3 pad, aligning it to
>> the function specified in the datasheet.
>>
>> Fixes: a9d562daa3c3 ("imx: Add iMX91 support")
>>
>> Signed-off-by: Francesco Valla <francesco@valla.it>
> 
> Nice catch!
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 

Just for completeness, I think there is another one: 
MX91_PAD_I2C2_SCL__GPIO1_IO3 should e MX91_PAD_I2C2_SCL__GPIO1_IO2

--
Regards
Javier Viguera
Digi International Inc.

Re: [PATCH] imx91: fix ENET1_TD3 pinmux for GPIO function

[Francesco Valla]

Hi,

On Thu, Nov 13, 2025 at 02:33:05PM +0100, Javier Viguera wrote:
> On 12/11/25 22:15, Fabio Estevam wrote:
> > Hi Francesco,
> > 
> > On Tue, Nov 11, 2025 at 10:19 AM Francesco Valla <francesco@valla.it> wrote:
> > > 
> > > Fix a typo in the GPIO function for the ENET1_TD3 pad, aligning it to
> > > the function specified in the datasheet.
> > > 
> > > Fixes: a9d562daa3c3 ("imx: Add iMX91 support")
> > > 
> > > Signed-off-by: Francesco Valla <francesco@valla.it>
> > 
> > Nice catch!
> > 
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > 
> 
> Just for completeness, I think there is another one:
> MX91_PAD_I2C2_SCL__GPIO1_IO3 should e MX91_PAD_I2C2_SCL__GPIO1_IO2
> 

Another nice catch. I'll send an updated patch with this fix too (and
your R-b tag).

Thank you

> --
> Regards
> Javier Viguera
> Digi International Inc.
> 
>

Regards,
Francesco