From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: alison.wang@nxp.com, angelo@kernel-space.org,
jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com,
u-boot@lists.denx.de
Subject: Re: [PATCH 2/3] m68k: Add support for M68040 CPU
Date: Sun, 21 Dec 2025 00:43:08 +0800 [thread overview]
Message-ID: <aUbSHO5Z1w86MG1e@google.com> (raw)
In-Reply-To: <20251218190032.GL303283@bill-the-cat>
Hi Tom,
On Thu, Dec 18, 2025 at 01:00:32PM -0600, Tom Rini wrote:
> On Thu, Dec 18, 2025 at 06:52:51PM +0000, Kuan-Wei Chiu wrote:
> > Add support for the Motorola 68040 architecture. Currently, m68k
> > support in U-Boot is primarily focused on ColdFire (MCF5xxx) variants.
> > Introduce the necessary infrastructure to support the classic M680x0
> > series, specifically targeting the M68040 as emulated by QEMU.
> >
> > The implementation includes exception vectors, early startup code, and
> > minimal CPU initialization and relocation stubs. It also defines the
> > standard m68k boot information structure used for passing hardware
> > information to the operating system. To ensure compatibility, ColdFire-
> > specific library objects such as cache and interrupt handling are
> > excluded from the build when M68040 is selected.
> >
> > Additionally, apply a specific workaround during the early memory
> > reservation stage. Use a manual loop to clear global data instead of
> > the standard memset() function, as utilizing memset() at this point was
> > observed to cause a hang on the QEMU platform.
> >
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> [snip]
> > diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
> > index 8ade6f7b9d1..a41c375f6be 100644
> > --- a/arch/m68k/Kconfig
> > +++ b/arch/m68k/Kconfig
> > @@ -56,6 +56,9 @@ config MCF5441x
> > select DM_SERIAL
> > bool
> >
> > +config M68040
> > + bool
> > +
>
> The file is unfortunately inconsistent about tabs vs spaces, but all the
> new options should be tab-indent only, and no extra blank lines added.
I'll fix this in v2.
BTW, do you think it would be helpful to add a check in checkpatch.pl
to warn about space indentation in Kconfig files?
Regards,
Kuan-Wei
next prev parent reply other threads:[~2025-12-20 23:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 18:52 [PATCH 0/3] m68k: Add support for QEMU virt machine Kuan-Wei Chiu
2025-12-18 18:52 ` [PATCH 1/3] serial: Add Goldfish TTY driver Kuan-Wei Chiu
2025-12-19 3:14 ` Yao Zi
2025-12-20 16:28 ` Kuan-Wei Chiu
2025-12-21 2:58 ` Yao Zi
2025-12-18 18:52 ` [PATCH 2/3] m68k: Add support for M68040 CPU Kuan-Wei Chiu
2025-12-18 19:00 ` Tom Rini
2025-12-20 16:43 ` Kuan-Wei Chiu [this message]
2025-12-22 16:20 ` Tom Rini
2025-12-21 4:53 ` Daniel Palmer
2025-12-21 7:25 ` Angelo Dureghello
2025-12-22 9:21 ` Kuan-Wei Chiu
2025-12-18 18:52 ` [PATCH 3/3] board: Add QEMU m68k virt board support Kuan-Wei Chiu
2025-12-18 19:04 ` Tom Rini
2025-12-20 16:48 ` Kuan-Wei Chiu
2025-12-21 4:37 ` Daniel Palmer
2025-12-22 9:03 ` Kuan-Wei Chiu
2025-12-18 19:00 ` [PATCH 0/3] m68k: Add support for QEMU virt machine Tom Rini
2025-12-20 16:39 ` Kuan-Wei Chiu
2025-12-21 4:15 ` Daniel Palmer
2025-12-22 8:44 ` Kuan-Wei Chiu
2025-12-22 9:20 ` Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUbSHO5Z1w86MG1e@google.com \
--to=visitorckw@gmail.com \
--cc=alison.wang@nxp.com \
--cc=angelo@kernel-space.org \
--cc=eleanor15x@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox