Re: [PATCH 3/3] board: Add QEMU m68k virt board support

[Kuan-Wei Chiu <visitorckw@gmail.com>]

Hi Tom,

On Thu, Dec 18, 2025 at 01:04:15PM -0600, Tom Rini wrote:
> On Thu, Dec 18, 2025 at 06:52:52PM +0000, Kuan-Wei Chiu wrote:
> 
> > Add support for the QEMU 'virt' machine on the m68k architecture. This
> > board emulates a generic machine based on the Motorola 68040 CPU
> > equipped with Goldfish virtual peripherals.
> > 
> > Introduce the necessary board configuration and initialization
> > infrastructure. The implementation includes logic to parse the QEMU
> > bootinfo interface, enabling dynamic detection of system RAM size to
> > adapt to the virtual machine's configuration.
> > 
> > Enable the Goldfish TTY driver to provide a serial console, which
> > facilitates interaction when running QEMU with the -nographic option.
> > Additionally, include comprehensive documentation covering build
> > instructions and usage examples to guide users in deploying U-Boot
> > within the virtualization environment.
> > 
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> [snip]
> > diff --git a/board/emulation/qemu-m68k/MAINTAINERS b/board/emulation/qemu-m68k/MAINTAINERS
> > new file mode 100644
> > index 00000000000..c2f4cc40a56
> > --- /dev/null
> > +++ b/board/emulation/qemu-m68k/MAINTAINERS
> > @@ -0,0 +1,10 @@
> > +QEMU M68K VIRT BOARD
> > +M:  Kuan-Wei Chiu <visitorckw@gmail.com>
> > +S:  Maintained
> > +F:  board/emulation/qemu-m68k/
> > +F:  board/emulation/common/
> > +F:  include/configs/qemu-m68k.h
> > +F:  configs/qemu-m68k_defconfig
> > +F:  arch/m68k/cpu/m68040/
> > +F:  arch/m68k/include/asm/bootinfo.h
> > +F:  doc/board/emulation/qemu-m68k.rst
> 
> There was Kconfig spacing issues here as well, but also MAINTAINERS
> files are usually tab not spaces. But if get_maintainer.pl is fine, OK.

Will convert them to tabs in v2.

> 
> > diff --git a/configs/qemu-m68k_defconfig b/configs/qemu-m68k_defconfig
> > new file mode 100644
> > index 00000000000..765ed9b7424
> > --- /dev/null
> > +++ b/configs/qemu-m68k_defconfig
> > @@ -0,0 +1,17 @@
> > +CONFIG_M68K=y
> > +CONFIG_TARGET_QEMU_M68K=y
> > +CONFIG_TEXT_BASE=0x00000000
> > +CONFIG_SYS_LOAD_ADDR=0x00000000
> > +CONFIG_SYS_MONITOR_LEN=262144
> > +CONFIG_SYS_BOOTM_LEN=0x1000000
> > +CONFIG_SYS_MALLOC_LEN=0x20000
> > +# CONFIG_DISPLAY_BOARDINFO is not set
> > +CONFIG_BAUDRATE=115200
> > +
> > +# CONFIG_OF_CONTROL is not set
> 
> This wasn't made with "make savedefconfig" and needs to be, please
> generate it that way.

Will rectify that in v2.

> 
> > diff --git a/doc/board/emulation/qemu-m68k.rst b/doc/board/emulation/qemu-m68k.rst
> > new file mode 100644
> > index 00000000000..19898e17cfc
> > --- /dev/null
> > +++ b/doc/board/emulation/qemu-m68k.rst
> > @@ -0,0 +1,38 @@
> > +.. SPDX-License-Identifier: GPL-2.0+
> > +.. Copyright (C) 2025, Kuan-Wei Chiu <visitorckw@gmail.com>
> 
> Docs are good, thank you. But it needs to update the index.rst file too
> to be included and also not trigger CI failure when building docs.

Sorry for missing that. I will fix it in v2 and ensure the docs build
successfully before respinning.

Regards,
Kuan-Wei