public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks
@ 2026-02-26 19:32 Ajit Singh
  2026-02-27 16:13 ` Casey Connolly
  2026-04-13  9:24 ` Sumit Garg
  0 siblings, 2 replies; 4+ messages in thread
From: Ajit Singh @ 2026-02-26 19:32 UTC (permalink / raw)
  To: u-boot, u-boot-qcom
  Cc: Lukasz Majewski, Casey Connolly, Neil Armstrong, Sumit Garg,
	Tom Rini, Luca Weiss, Ajit Singh

Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks.
Required on platforms where SDCC1 is used for eMMC.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a3cc092196ef63570c8744c3ac88c3c6c67ab44b

Signed-off-by: Ajit Singh <blfizzyy@gmail.com>
---
 drivers/clk/qcom/clock-sc7280.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
index 7b6ed826023..acdaccf7462 100644
--- a/drivers/clk/qcom/clock-sc7280.c
+++ b/drivers/clk/qcom/clock-sc7280.c
@@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
 	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
 	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
 	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
 };
 
 static int sc7280_enable(struct clk *clk)
-- 
2.50.1 (Apple Git-155)


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks
  2026-02-26 19:32 [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks Ajit Singh
@ 2026-02-27 16:13 ` Casey Connolly
  2026-03-26  9:35   ` Ajit Singh
  2026-04-13  9:24 ` Sumit Garg
  1 sibling, 1 reply; 4+ messages in thread
From: Casey Connolly @ 2026-02-27 16:13 UTC (permalink / raw)
  To: Ajit Singh, u-boot, u-boot-qcom
  Cc: Lukasz Majewski, Neil Armstrong, Sumit Garg, Tom Rini, Luca Weiss



On 26/02/2026 20:32, Ajit Singh wrote:
> Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks.
> Required on platforms where SDCC1 is used for eMMC.
> 
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a3cc092196ef63570c8744c3ac88c3c6c67ab44b
> 
> Signed-off-by: Ajit Singh <blfizzyy@gmail.com>

Reviewed-by: Casey Connolly <casey.connolly@linaro.org>

> ---
>  drivers/clk/qcom/clock-sc7280.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
> index 7b6ed826023..acdaccf7462 100644
> --- a/drivers/clk/qcom/clock-sc7280.c
> +++ b/drivers/clk/qcom/clock-sc7280.c
> @@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
>  	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
>  };
>  
>  static int sc7280_enable(struct clk *clk)

-- 
// Casey (she/her)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks
  2026-02-27 16:13 ` Casey Connolly
@ 2026-03-26  9:35   ` Ajit Singh
  0 siblings, 0 replies; 4+ messages in thread
From: Ajit Singh @ 2026-03-26  9:35 UTC (permalink / raw)
  To: Casey Connolly, u-boot, u-boot-qcom
  Cc: u-boot, u-boot-qcom, Lukasz Majewski, Neil Armstrong, Sumit Garg,
	Tom Rini, Luca Weiss

Hi, Gentle ping on this patch.
It already has a Reviewed-by from Casey, so I wanted to check whether it can be picked up.

Thanks,
Ajit

> On Fri, Feb 27, 2026 at 05:13:26PM +0530, Casey Connolly wrote:
> Reviewed-by: Casey Connolly <casey.connolly@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks
  2026-02-26 19:32 [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks Ajit Singh
  2026-02-27 16:13 ` Casey Connolly
@ 2026-04-13  9:24 ` Sumit Garg
  1 sibling, 0 replies; 4+ messages in thread
From: Sumit Garg @ 2026-04-13  9:24 UTC (permalink / raw)
  To: Ajit Singh
  Cc: u-boot, u-boot-qcom, Lukasz Majewski, Casey Connolly,
	Neil Armstrong, Tom Rini, Luca Weiss

On Fri, Feb 27, 2026 at 01:02:17AM +0530, Ajit Singh wrote:
> Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks.
> Required on platforms where SDCC1 is used for eMMC.
> 
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a3cc092196ef63570c8744c3ac88c3c6c67ab44b
> 
> Signed-off-by: Ajit Singh <blfizzyy@gmail.com>
> ---
>  drivers/clk/qcom/clock-sc7280.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
> index 7b6ed826023..acdaccf7462 100644
> --- a/drivers/clk/qcom/clock-sc7280.c
> +++ b/drivers/clk/qcom/clock-sc7280.c
> @@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
>  	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
>  };
>  
>  static int sc7280_enable(struct clk *clk)
> -- 
> 2.50.1 (Apple Git-155)
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-13  9:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 19:32 [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks Ajit Singh
2026-02-27 16:13 ` Casey Connolly
2026-03-26  9:35   ` Ajit Singh
2026-04-13  9:24 ` Sumit Garg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox