* [PATCH] power: regulator: pfuze100: Fix unchecked pmic_reg_read, return value
@ 2026-05-08 20:11 Francois Berder
2026-05-13 10:53 ` Peng Fan
0 siblings, 1 reply; 2+ messages in thread
From: Francois Berder @ 2026-05-08 20:11 UTC (permalink / raw)
To: u-boot; +Cc: Jaehoon Chung, Peng Fan, Tom Rini
pmic_reg_read returns a negative value if an error occurs. This
commit adds a missing check after calling pmic_reg_read.
Signed-off-by: Francois Berder <fberder@outlook.fr>
---
drivers/power/regulator/pfuze100.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/power/regulator/pfuze100.c b/drivers/power/regulator/pfuze100.c
index 77c82a00b65..57af16cfbb9 100644
--- a/drivers/power/regulator/pfuze100.c
+++ b/drivers/power/regulator/pfuze100.c
@@ -550,6 +550,8 @@ static int pfuze100_regulator_val(struct udevice *dev, int op, int *uV)
return -EINVAL;
}
val = pmic_reg_read(dev->parent, desc->vsel_reg);
+ if (val < 0)
+ return val;
if (desc->high_volt_mask && (val & desc->high_volt_mask)) {
min_uV = desc->high_volt_desc->min_uV;
uV_step = desc->high_volt_desc->uV_step;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: regulator: pfuze100: Fix unchecked pmic_reg_read, return value
2026-05-08 20:11 [PATCH] power: regulator: pfuze100: Fix unchecked pmic_reg_read, return value Francois Berder
@ 2026-05-13 10:53 ` Peng Fan
0 siblings, 0 replies; 2+ messages in thread
From: Peng Fan @ 2026-05-13 10:53 UTC (permalink / raw)
To: Francois Berder; +Cc: u-boot, Jaehoon Chung, Peng Fan, Tom Rini
On Fri, May 08, 2026 at 10:11:35PM +0200, Francois Berder wrote:
>pmic_reg_read returns a negative value if an error occurs. This
>commit adds a missing check after calling pmic_reg_read.
>
>Signed-off-by: Francois Berder <fberder@outlook.fr>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-13 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-08 20:11 [PATCH] power: regulator: pfuze100: Fix unchecked pmic_reg_read, return value Francois Berder
2026-05-13 10:53 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox