U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: dmukhin@ford.com
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: dmukhin@ford.com, u-boot@lists.denx.de, sjg@chromium.org,
	trini@konsulko.com
Subject: Re: [PATCH v2 0/6] nvme: few fixups
Date: Thu, 4 Jun 2026 20:59:28 -0700	[thread overview]
Message-ID: <aiJJoBJK0B54Zomy@kraken> (raw)
In-Reply-To: <dbdc5f45-b4cd-4dae-8cf2-5e6172d5fc2d@linaro.org>

Hi Neil,

Thanks for the feedback!

On Thu, Jun 04, 2026 at 08:32:50AM +0200, neil.armstrong@linaro.org wrote:
> Hi,
> 
> On 5/29/26 05:44, dmukhin@ford.com wrote:
> > The series adds few fixes for NVMe subsystem.
> > 
> > Patch 1 adds logline for tracing misbehaving NVMe drives.
> > Patch 2 adds plumbing for blk_flush()/blk_dflush().
> > Patch 3 introduces NVMe flush command.
> > Patch 4 enables `flush` for the currently selected block device.
> 
> As my thread on v1, please enable FUA or disable WC to be sure we don't use the WC.

Yes, sorry, I did not have time to respond to v1 feedback (just sent out
an email):

   https://lore.kernel.org/u-boot/aiJFzMdcCu5sAktz@kraken/

I will look into FUA for NVMe.

But I also think it makes sense to add flush to the code base as
an alternative solution for ensuring data is stored.

--
Denis

      reply	other threads:[~2026-06-05  3:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29  3:44 [PATCH v2 0/6] nvme: few fixups dmukhin
2026-05-29  3:44 ` [PATCH v2 1/6] drivers: nvme: Log I/O timeouts dmukhin
2026-05-29  9:56   ` Simon Glass
2026-05-29  3:44 ` [PATCH v2 2/6] drivers: block: Introduce blk_flush()/blk_dflush() dmukhin
2026-05-29  9:57   ` Simon Glass
2026-07-16 22:28     ` dmukhin
2026-05-29  3:44 ` [PATCH v2 3/6] drivers: nvme: Implement flush command dmukhin
2026-05-29  9:57   ` Simon Glass
2026-05-29  3:44 ` [PATCH v2 4/6] cmd: Add flush support for all blk devices dmukhin
2026-05-29  9:57   ` Simon Glass
2026-06-05  3:55     ` dmukhin
2026-06-03 17:43   ` Sean Anderson
2026-06-04 17:01     ` Simon Glass
2026-06-05  3:53     ` dmukhin
2026-05-29  3:44 ` [PATCH v2 5/6] drivers: nvme: Export nvme_shutdown() dmukhin
2026-05-29  9:57   ` Simon Glass
2026-05-29  3:44 ` [PATCH v2 6/6] docs: nvme: Update QEMU command for testing dmukhin
2026-05-29  9:58   ` Simon Glass
2026-05-29  9:58 ` [v2,0/6] nvme: few fixups Simon Glass
2026-06-03 16:22 ` (subset) [PATCH v2 0/6] " Neil Armstrong
2026-06-04  6:32 ` neil.armstrong
2026-06-05  3:59   ` dmukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiJJoBJK0B54Zomy@kraken \
    --to=dmukhin@ford.com \
    --cc=neil.armstrong@linaro.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox