Re: [PATCH v2 2/6] drivers: block: Introduce blk_flush()/blk_dflush()

[dmukhin@ford.com]

On Fri, May 29, 2026 at 04:57:06AM -0500, Simon Glass wrote:
[..]
> cached contents are still valid. Erase/write mutate device state, but
> flush does not. Please drop the blkcache_invalidate() call (and the
> matching one in the non-DM inline below).
> 
> > diff --git a/include/blk.h b/include/blk.h
> > @@ -99,6 +99,7 @@ struct blk_desc {
> >       unsigned long   (*block_erase)(struct blk_desc *block_dev,
> >                                      lbaint_t start,
> >                                      lbaint_t blkcnt);
> > +     unsigned long   (*block_flush)(struct blk_desc *block_dev);
> 
> This field lives in the !CONFIG_BLK (legacy) branch, but no legacy
> driver in the series wires it up. The only consumer (NVMe) is DM-only.
> Are you going to need the legacy plumbing?

blk_dflush() is used in flush subcommand in cmd/blk_common.c

(I also used it for tests in v3 of the upcoming series).

--
Denis