From: Robert P. J. Day <rpjday@crashcourse.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_mem.c: Fix simple typoes, no functional changes.
Date: Sun, 3 Feb 2013 04:08:19 -0500 (EST) [thread overview]
Message-ID: <alpine.DEB.2.02.1302030404210.5835@oneiric> (raw)
In-Reply-To: <510D67C9.5010709@myspectrum.nl>
On Sat, 2 Feb 2013, Jeroen Hofstee wrote:
> On 02/02/2013 05:04 PM, Robert P. J. Day wrote:
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > based on perusal of entire file as i was reading code. undoubtedly
> > more of these file-wide proofreads coming if no objections ...
> >
> > diff --git a/common/cmd_mem.c b/common/cmd_mem.c
> > index 0f3ffc8..2568c04 100644
> > --- a/common/cmd_mem.c
> > +++ b/common/cmd_mem.c
> > @@ -462,7 +462,7 @@ static int do_mem_loop(cmd_tbl_t *cmdtp, int flag, int
> > argc,
> > if (argc < 3)
> > return CMD_RET_USAGE;
> >
> > - /* Check for a size spefication.
> > + /* Check for a size specification.
> > * Defaults to long if no or incorrect specification.
> > */
> > if ((size = cmd_get_data_size(argv[0], 4)) < 0)
.. snip ...
> nitpicking: the summary line should not end with a dot.
point taken, i can resubmit.
> multi line comments in u-boot are commonly
>
> /*
> * I span
> * multiple lines
> */
>
> So while at it, you might want to add the empty opening line as well.
in cases like this, it's kind of a judgment call. if that's truly a
strict standard, then sure. but i'm pretty sure there's a *lot* of
the above type of comment in the source and when i'm just fixing
comments, i prefer to make as unobtrusive a change as possible.
i'll let wolfgang decide, and i'll go with whatever he chooses.
note carefully that you used the phrase "commonly", without claiming
that it's a hard and fast standard, which is why i left it alone.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2013-02-03 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 16:04 [U-Boot] [PATCH] cmd_mem.c: Fix simple typoes, no functional changes Robert P. J. Day
2013-02-02 19:23 ` Jeroen Hofstee
2013-02-03 9:08 ` Robert P. J. Day [this message]
2013-02-03 10:16 ` Wolfgang Denk
2013-02-03 10:23 ` Robert P. J. Day
2013-02-03 12:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1302030404210.5835@oneiric \
--to=rpjday@crashcourse.ca \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox