From: Marek Vasut <marex@denx.de>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Michal Simek <michal.simek@amd.com>,
Sean Anderson <seanga2@gmail.com>, Angus Ainslie <angus@akkea.ca>,
Lukasz Majewski <lukma@denx.de>,
Jan Kiszka <jan.kiszka@siemens.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v4 08/10] phy: socionext: Add UniPhier USB3 PHY driver
Date: Mon, 20 Feb 2023 16:51:22 +0100 [thread overview]
Message-ID: <b93a91eb-e0da-c364-6138-d4eaef677fa2@denx.de> (raw)
In-Reply-To: <20230220055034.4889-9-hayashi.kunihiko@socionext.com>
On 2/20/23 06:50, Kunihiko Hayashi wrote:
[...]
> +static int uniphier_usb3phy_probe(struct udevice *dev)
> +{
[...]
> + priv->rst_parent = devm_reset_control_get_optional(dev, "gio");
> + if (IS_ERR(priv->rst_parent)) {
> + printf("Failed to get parent reset\n");
> + return PTR_ERR(priv->rst_parent);
> + }
> +
> + if (priv->clk_parent) {
> + ret = clk_enable(priv->clk_parent);
> + if (ret)
> + return ret;
> + }
Missing newline here.
> + if (priv->rst_parent) {
> + ret = reset_deassert(priv->rst_parent);
> + if (ret)
> + goto out_clk_parent;
> + }
Reviewed-by: Marek Vasut <marex@denx.de>
[...]
next prev parent reply other threads:[~2023-02-20 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 5:50 [PATCH v4 00/10] usb: dwc3: Refactor dwc3-generic and apply to dwc3-uniphier Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 01/10] usb: dwc3: Look up reference clock DT phandle in both controller DT nodes Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 02/10] usb: dwc3-generic: Allow different controller DT node pattern Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 03/10] usb: dwc3-generic: Add clock initialization in child DT node Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 04/10] usb: dwc3-generic: Export glue structures and functions Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 05/10] usb: dwc3-generic: Add the size of regs property to glue structure Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 06/10] reset: uniphier: Add USB glue reset support Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 07/10] clk: uniphier: Add missing USB SS-PHY clocks Kunihiko Hayashi
2023-02-20 15:51 ` Marek Vasut
2023-02-20 5:50 ` [PATCH v4 08/10] phy: socionext: Add UniPhier USB3 PHY driver Kunihiko Hayashi
2023-02-20 15:51 ` Marek Vasut [this message]
2023-02-20 5:50 ` [PATCH v4 09/10] usb: dwc3-uniphier: Use dwc3-generic instead of xhci-dwc3 Kunihiko Hayashi
2023-02-20 5:50 ` [PATCH v4 10/10] uniphier_defconfig: Disable USB_XHCI_DWC3 Kunihiko Hayashi
2023-02-20 15:53 ` [PATCH v4 00/10] usb: dwc3: Refactor dwc3-generic and apply to dwc3-uniphier Marek Vasut
2023-02-22 2:00 ` Kunihiko Hayashi
2023-02-22 3:27 ` Marek Vasut
2023-02-22 14:39 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93a91eb-e0da-c364-6138-d4eaef677fa2@denx.de \
--to=marex@denx.de \
--cc=angus@akkea.ca \
--cc=hayashi.kunihiko@socionext.com \
--cc=jan.kiszka@siemens.com \
--cc=lukma@denx.de \
--cc=michal.simek@amd.com \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox