From: Stefan Agner <stefan@agner.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: nand: mxs: fix cache alignment for cache lines >32
Date: Wed, 03 Aug 2016 12:43:00 -0700 [thread overview]
Message-ID: <c0bb71d388fc6a6ded72713b36632957@agner.ch> (raw)
In-Reply-To: <CAPnjgZ0TkP0xWrnGKDantLCC+m40cpc0-65he32KML32JOg-Pw@mail.gmail.com>
On 2016-08-03 12:08, Simon Glass wrote:
> Hi Fabio,
>
> On 3 August 2016 at 12:44, Fabio Estevam <festevam@gmail.com> wrote:
>> Hi Simon,
>>
>> On Wed, Aug 3, 2016 at 3:35 PM, Simon Glass <sjg@chromium.org> wrote:
>>
>>> Actually I think these are bugs and should be fixed. In this case,
>>> from what I can tell netboot_common() should cache-align the size in
>>> the call to:
>>>
>>> /* flush cache */
>>> flush_cache(load_addr, size);
>>
>> Do you mean like this?
>>
>> --- a/cmd/net.c
>> +++ b/cmd/net.c
>> @@ -244,6 +244,8 @@ static int netboot_common(enum proto_t proto, cmd_tbl_t *cmd
>> }
>>
>> /* flush cache */
>> + load_addr &= ~(CONFIG_SYS_CACHELINE_SIZE - 1);
>> + size = ALIGN(size, CONFIG_SYS_CACHELINE_SIZE);
>> flush_cache(load_addr, size);
>>
>> bootstage_mark(BOOTSTAGE_ID_NET_LOADED);
>>
>> This makes the net warnings go away.
>>
>> There is still this one that I am seeing:
>>
>> Kernel image @ 0x80800000 [ 0x000000 - 0x6fea70 ]
>> ## Flattened Device Tree blob at 83000000
>> Booting using the fdt blob at 0x83000000
>> Using Device Tree in place at 83000000, end 83009c5d
>>
>> Starting kernel ...
>>
>> CACHE: Misaligned operation at range [00900000, 00900529]
>> [ 0.000000] Booting Linux on physical CPU 0x0
>>
>> Any ideas where it may come from?
>
> Not really...maybe boot_ramdisk_high()?
>
> It's clearly pretty late in the process.
That looks like a SRAM address, and it is used for the secure stuff for
instance (CONFIG_ARMV7_SECURE_BASE).
I bet its from relocate_secure_section in arch/arm/cpu/armv7/virt-v7.c.
Will send out a patch for that.
--
Stefan
next prev parent reply other threads:[~2016-08-03 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 6:55 [U-Boot] [PATCH] mtd: nand: mxs: fix cache alignment for cache lines >32 Stefan Agner
2016-08-02 8:17 ` Stefano Babic
2016-08-03 7:57 ` Stefano Babic
2016-08-03 13:51 ` Fabio Estevam
2016-08-03 16:13 ` Stefan Agner
2016-08-03 17:39 ` Fabio Estevam
2016-08-03 18:09 ` Tom Rini
2016-08-03 18:29 ` Fabio Estevam
2016-08-03 18:35 ` Simon Glass
2016-08-03 18:44 ` Fabio Estevam
2016-08-03 19:08 ` Simon Glass
2016-08-03 19:43 ` Stefan Agner [this message]
2016-08-03 19:18 ` Stefan Agner
2016-08-03 20:05 ` Hannes Schmelzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0bb71d388fc6a6ded72713b36632957@agner.ch \
--to=stefan@agner.ch \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox