U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: u-boot@lists.denx.de, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH] usb: kbd: allow probing even if usbkbd not in stdin
Date: Mon, 27 Jun 2022 13:39:03 +0200	[thread overview]
Message-ID: <c5afd242-e6aa-3234-3049-e690720bf8d8@denx.de> (raw)
In-Reply-To: <20220627120332.23bd6bcf@kmaincent-XPS-13-7390>

On 6/27/22 12:03, Köry Maincent wrote:
> Hello Marek,
> 
> On Fri, 24 Jun 2022 20:12:31 +0200
> Marek Vasut <marex@denx.de> wrote:
> 
>> On 6/22/22 10:59, kory.maincent@bootlin.com wrote:
>>> From: Kory Maincent <kory.maincent@bootlin.com>
>>>
>>> For now the driver does not probe if usbkbd was not present in stdin.
>>> This presents two issues, we can not probe the driver before setting stdin
>>
>> Environment should be up and running before USB, so this is likely not a
>> problem.
> 
> Having a driver probing only in this specific state is weird?
> It should probe whatever the state of stdin.
> 
>>
>>> and we can not use this driver in other manner than stdin console.
>>>
>>> This patch fixes this by adding an else statement. It simply probes the
>>> driver without console management in the case "usbkbd" is not in stdin.
>>
>> Can you document the usecase in a bit more detail ?
> 
> My usecase is to get a key press from the USB keyboard and do some thing about
> it in board_init. I do not want to multiplex the keyboard input to stdin but I
> still want to read character from it.

All right, understood, both. Thanks for clarification.

I applied this to usb/next , I hope that's OK ?

  reply	other threads:[~2022-06-27 11:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  8:59 [PATCH] usb: kbd: allow probing even if usbkbd not in stdin kory.maincent
2022-06-24 18:12 ` Marek Vasut
2022-06-27 10:03   ` Köry Maincent
2022-06-27 11:39     ` Marek Vasut [this message]
2022-06-27 12:27       ` Köry Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5afd242-e6aa-3234-3049-e690720bf8d8@denx.de \
    --to=marex@denx.de \
    --cc=kory.maincent@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox