From: Chen Huei Lok <chen.huei.lok@altera.com>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Lukasz Majewski <lukma@denx.de>,
Tien Fong Chee <tien.fong.chee@altera.com>,
Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>,
Dinesh Maniyam <dinesh.maniyam@altera.com>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Kok Kiang Hea <kok.kiang.hea@altera.com>,
Chen Huei Lok <chen.huei.lok@altera.com>
Subject: [PATCH v2 0/2] drivers: clk: n5x: Fix and clean up EMAC clock source selection
Date: Tue, 23 Jun 2026 10:07:50 +0800 [thread overview]
Message-ID: <cover.1782178282.git.chen.huei.lok@altera.com> (raw)
This series fixes the EMAC clock source selection in the N5X clock
driver and then cleans it up to match the Agilex clock driver.
Patch 1 is the functional fix that was sent as v1: the mask was applied
after the shift instead of before, so EMAC always read the clock source
as emaca_free_clk. Patch 2 is a follow-up readability change that
replaces the open-coded mask-and-shift with FIELD_GET(), as suggested by
Tien Fong on the v1 review, aligning N5X with the existing Agilex usage.
Tested on Intel SoCFPGA N5X SoCDK hardware.
v1->v2:
--------
- No functional change to the fix (patch 1).
- New patch 2: use FIELD_GET() for the EMAC clock source select field,
for consistency with the Agilex clock driver (Tien Fong's review nit).
History:
--------
[v1] https://patchwork.ozlabs.org/project/uboot/patch/20260507090215.18074-1-chen.huei.lok@altera.com/
Chen Huei Lok (2):
drivers: clk: n5x: Fix incorrect EMAC clock source selection
drivers: clk: n5x: Use FIELD_GET for EMAC clock source selection
drivers/clk/altera/clk-n5x.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--
2.43.7
next reply other threads:[~2026-06-23 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 2:07 Chen Huei Lok [this message]
2026-06-23 2:07 ` [PATCH v2 1/2] drivers: clk: n5x: Fix incorrect EMAC clock source selection Chen Huei Lok
2026-06-23 2:07 ` [PATCH v2 2/2] drivers: clk: n5x: Use FIELD_GET for " Chen Huei Lok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1782178282.git.chen.huei.lok@altera.com \
--to=chen.huei.lok@altera.com \
--cc=alif.zakuan.yuslaimi@altera.com \
--cc=boon.khai.ng@altera.com \
--cc=dinesh.maniyam@altera.com \
--cc=kok.kiang.hea@altera.com \
--cc=lukma@denx.de \
--cc=tien.fong.chee@altera.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox