public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Heider <a.heider@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] xenon_sdhci: support for HS200 mode
Date: Mon, 31 Aug 2020 10:10:50 +0200	[thread overview]
Message-ID: <d7589954-167d-08dd-1926-9aa4a38eaab2@gmail.com> (raw)
In-Reply-To: <20200831075017.26mj7u2z3su26qdl@pali>

On 31/08/2020 09:50, Pali Roh?r wrote:
> On Monday 31 August 2020 05:25:37 Andre Heider wrote:
>> From: Wojciech Macek <wma@semihalf.com>
>>
>> Add support for Marvell Xenon SDHCI HS200 mode.
>>
>> Changes focue mostly on correct PHY initialization.
>> All procedure is similar to the one done by Linux
>> driver, but simplified.
>>
>> Change-Id: I5e2396eeb23784f495abc18ea5a2eb7a92390730
>> Signed-off-by: Wojciech Macek <wma@semihalf.com>
>> Reviewed-on: http://vgitil04.il.marvell.com:8080/59230
>> Tested-by: iSoC Platform CI <ykjenk@marvell.com>
>> Reviewed-by: Grzegorz Jaszczyk <jaz@semihalf.com>
>> Reviewed-by: Kostya Porotchkin <kostap@marvell.com>
>> Reviewed-by: Igal Liberman <igall@marvell.com>
>> [a.heider: adapt to mainline]
>> Signed-off-by: Andre Heider <a.heider@gmail.com>
>> ---
>> Missing downstream patch, noticed while diffing branches:
>> https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/commit/387232507a0d9dda3990284221eaf87d7541dd02
> 
> Hello Andre! Why is this patch needed? Or what it is fixing?
> I tested upstream U-Boot with all previous patches on Turris MOX and
> Espressobin and SD cards worked fine.

My primary aim was to reduces the diff against the downstream fork, to 
make upstream work just as well.

But the HS200/400 mode is not used by those two boards, but by:
arch/arm/dts/armada-3720-uDPU.dts
arch/arm/dts/armada-3720-db.dts

And my other patch for espressobin-emmc is using it too. They're 
independent, so it works without it, just not as fast.

Having said that, I don't have either of those boards, so I haven't 
tested it myself. But the patches have been downstream for over two 
years, so I'd say they're well tested since everybody runs a downstream 
firmware (which will hopefully change now ;)

Regards,
Andre

  reply	other threads:[~2020-08-31  8:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  3:25 [PATCH 1/2] xenon_sdhci: support for HS200 mode Andre Heider
2020-08-31  3:25 ` [PATCH 2/2] pcie: pcie_advk: move setting of reference clock to the pcie driver Andre Heider
2020-08-31  7:52   ` Pali Rohár
2020-08-31  8:10     ` Andre Heider
2020-09-02  7:11     ` Andre Heider
2020-09-02 12:35       ` Marek Behún
2020-08-31  7:50 ` [PATCH 1/2] xenon_sdhci: support for HS200 mode Pali Rohár
2020-08-31  8:10   ` Andre Heider [this message]
2020-08-31 11:39     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7589954-167d-08dd-1926-9aa4a38eaab2@gmail.com \
    --to=a.heider@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox