public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Heider <a.heider@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/2] pcie: pcie_advk: move setting of reference clock to the pcie driver
Date: Wed, 2 Sep 2020 09:11:52 +0200	[thread overview]
Message-ID: <e4e2f425-0423-6b70-361c-9d3f66aad2d2@gmail.com> (raw)
In-Reply-To: <20200831075218.qth4f2o3j3jsmmv4@pali>

On 31/08/2020 09:52, Pali Roh?r wrote:
> On Monday 31 August 2020 05:25:38 Andre Heider wrote:
>> From: Grzegorz Jaszczyk <jaz@semihalf.com>
>>
>> The settings of reference clock is done via pcie address space and not
>> comphy address space - move the settings in appropriate place.
>>
>> This aligns hw initialization of pcie advk with Linux and also will allow
>> to get rid of not comphy related operation from the comphy driver.
>>
>> Change-Id: I9cc2e8f3e415a880dfb01d10cc8db73b7e81a605
>> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
>> Reviewed-on: http://vgitil04.il.marvell.com:8080/59619
>> Reviewed-by: Igal Liberman <igall@marvell.com>
>> Tested-by: iSoC Platform CI <ykjenk@marvell.com>
>> [a.heider: adapt to mainline]
>> Signed-off-by: Andre Heider <a.heider@gmail.com>
>> ---
>> Missing downstream patch, noticed while diffing branches:
>> https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/commit/e3d9c015d434f755578a86a4b6b3acd17d69238a
> 
> It looks like this patch only moves initialization code from one file to
> another. It is fixing some issue? I have tested PCIe on both MOX and
> Espressobin and it worked fine. If there is no issue I would rather wait
> for Marek comphy patches which should completely remove current marvell
> comphy driver from u-boot.

I just found out that Marek's patches cover this, so this patch can be 
dropped:
https://patchwork.ozlabs.org/project/uboot/patch/20200419154850.25868-8-marek.behun at nic.cz/

Thanks,
Andre

  parent reply	other threads:[~2020-09-02  7:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  3:25 [PATCH 1/2] xenon_sdhci: support for HS200 mode Andre Heider
2020-08-31  3:25 ` [PATCH 2/2] pcie: pcie_advk: move setting of reference clock to the pcie driver Andre Heider
2020-08-31  7:52   ` Pali Rohár
2020-08-31  8:10     ` Andre Heider
2020-09-02  7:11     ` Andre Heider [this message]
2020-09-02 12:35       ` Marek Behún
2020-08-31  7:50 ` [PATCH 1/2] xenon_sdhci: support for HS200 mode Pali Rohár
2020-08-31  8:10   ` Andre Heider
2020-08-31 11:39     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4e2f425-0423-6b70-361c-9d3f66aad2d2@gmail.com \
    --to=a.heider@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox