[PATCH 1/2] doc: imx8mp_evk: Remove unneeded export ATF_LOAD_ADDR line

[PATCH 1/2] doc: imx8mp_evk: Remove unneeded export ATF_LOAD_ADDR line

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

Originally, exporting the ATF_LOAD_ADDR was required, but since binman has
been used to generate the flash.bin, it is no longer needed to do
such manual export.

The ATF address is now passed via binman in imx8mp-u-boot.dtsi:

	atf {
		description = "ARM Trusted Firmware";
		type = "firmware";
		arch = "arm64";
		compression = "none";
		load = <0x970000>;
		entry = <0x970000>;

		atf_blob: atf-blob {
			filename = "bl31.bin";
			type = "atf-bl31";
		};
	};

Remove the  unneeded export ATF_LOAD_ADDR line.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 doc/board/nxp/imx8mp_evk.rst | 1 -
 1 file changed, 1 deletion(-)

diff --git a/doc/board/nxp/imx8mp_evk.rst b/doc/board/nxp/imx8mp_evk.rst
index e7cc7b396b57..e106c3c71872 100644
--- a/doc/board/nxp/imx8mp_evk.rst
+++ b/doc/board/nxp/imx8mp_evk.rst
@@ -44,7 +44,6 @@ Build U-Boot
    $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin ./build/
    $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin ./build/
    $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_202006.bin ./build/
-   $ export ATF_LOAD_ADDR=0x970000
    $ make O=build
 
 Burn the flash.bin to the MicroSD card at offset 32KB:
-- 
2.34.1

[PATCH 2/2] doc: imx8mp_evk: Use in-tree build in the example

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

To make it consistent with the instructions from other NXP imx8m boards,
such as imx8mm-evk and imx8mn-evk, use U-Boot in-tree build in the
examples.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 doc/board/nxp/imx8mp_evk.rst | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/doc/board/nxp/imx8mp_evk.rst b/doc/board/nxp/imx8mp_evk.rst
index e106c3c71872..0297cc8ffc16 100644
--- a/doc/board/nxp/imx8mp_evk.rst
+++ b/doc/board/nxp/imx8mp_evk.rst
@@ -37,20 +37,22 @@ Build U-Boot
 
 .. code-block:: bash
 
+Note: builddir is U-Boot build directory (source directory for in-tree builds).
+
    $ export CROSS_COMPILE=aarch64-poky-linux-
    $ make O=build imx8mp_evk_defconfig
-   $ cp ../imx-atf/build/imx8mp/release/bl31.bin ./build/bl31.bin
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_202006.bin ./build/
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin ./build/
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin ./build/
-   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_202006.bin ./build/
-   $ make O=build
+   $ cp ../imx-atf/build/imx8mp/release/bl31.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_202006.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin $(builddir)
+   $ cp ../firmware-imx-8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_202006.bin $(builddir)
+   $ make
 
 Burn the flash.bin to the MicroSD card at offset 32KB:
 
 .. code-block:: bash
 
-   $sudo dd if=build/flash.bin of=/dev/sd[x] bs=1K seek=32 conv=notrunc; sync
+   $ sudo dd if=flash.bin of=/dev/sd[x] bs=1K seek=32 conv=notrunc; sync
 
 Boot
 ----
-- 
2.34.1

Re: [PATCH 2/2] doc: imx8mp_evk: Use in-tree build in the example

[Peng Fan]

On 8/7/2023 9:42 PM, Fabio Estevam wrote:
> From: Fabio Estevam<festevam@denx.de>
> 
> To make it consistent with the instructions from other NXP imx8m boards,
> such as imx8mm-evk and imx8mn-evk, use U-Boot in-tree build in the
> examples.
> 
> Signed-off-by: Fabio Estevam<festevam@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Re: [PATCH 1/2] doc: imx8mp_evk: Remove unneeded export ATF_LOAD_ADDR line

[Peng Fan]

On 8/7/2023 9:42 PM, Fabio Estevam wrote:
> From: Fabio Estevam<festevam@denx.de>
> 
> Originally, exporting the ATF_LOAD_ADDR was required, but since binman has
> been used to generate the flash.bin, it is no longer needed to do
> such manual export.
> 
> The ATF address is now passed via binman in imx8mp-u-boot.dtsi:
> 
> 	atf {
> 		description = "ARM Trusted Firmware";
> 		type = "firmware";
> 		arch = "arm64";
> 		compression = "none";
> 		load = <0x970000>;
> 		entry = <0x970000>;
> 
> 		atf_blob: atf-blob {
> 			filename = "bl31.bin";
> 			type = "atf-bl31";
> 		};
> 	};
> 
> Remove the  unneeded export ATF_LOAD_ADDR line.
> 
> Signed-off-by: Fabio Estevam<festevam@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>